3

Similar question has been asked here. But that does not provide answer.

try {
        object = (Dev)Class.forName("Dev").newInstance();
    } catch (Exception e) 
    {
        throw new RuntimeException("Devis not available");
    }
    finally
    {
        return object;  
    }

But finally block gives warning :

finally block does not complete normally

But as per my understating, finally block always gets executed and will return the object. Why warning says that it will not get completed normally?

Community
  • 1
  • 1
codingenious
  • 8,385
  • 12
  • 60
  • 90
  • 1
    Because the definition of your object is in try block which may or may not complete as expected. Hence. – Ritikesh Apr 01 '14 at 09:14
  • 1
    @Ritikesh In that case finally will return null. But it will get executed. – codingenious Apr 01 '14 at 09:19
  • [this](http://stackoverflow.com/a/18205628/2817802) answer might be useful – Baby Apr 01 '14 at 09:24
  • Also have a look at these questions: [Multiple returns: Which one sets the final return value?](http://stackoverflow.com/questions/2309964/multiple-returns-which-one-sets-the-final-return-value) and [try catch finally return, clarification in JAVA](http://stackoverflow.com/questions/15225819/try-catch-finally-return-clarification-in-java) – Balder Apr 01 '14 at 09:31

4 Answers4

5

The problem is that the finally block would remove any exceptions being thrown since it would issue a "normal" return.

From the JLS spec:

Abrupt completion of a finally clause can disrupt the transfer of control initiated by a return statement.

and (more relevant in your case):

Note that abrupt completion of a finally clause can disrupt the transfer of control initiated by a throw statement.

Thomas
  • 87,414
  • 12
  • 119
  • 157
4

There are so many explanations about the finally block in a try-catch-finally statement. Go and search for it.

Quick explanation anyway: The finally block is always run, regardless whether an exception was thrown (and maybe caught) or not. If a finally block terminates in an unnormal way (such as itself throwing an excpetion or returning a value) this will always override what was done in the try block or a catch block. That also means that these are got lost.

The conclusion: Never throw an exception ot return a value from the finally block. Only use it for cleaning up processes.

Seelenvirtuose
  • 20,273
  • 6
  • 37
  • 66
0

try this. If you are throwing an exception than there is something wrong with object. just return it before the catch.

try {
    object = (Dev)Class.forName("Dev").newInstance();
         return object;
} catch (Exception e) 
{
    throw new RuntimeException("Devis not available");

}
user2066728
  • 82
  • 7
0

Returning from finally is a bad practice in java. It may result in many unexpected outputs. Check below link for some of such examples: http://www.cs.arizona.edu/projects/sumatra/hallofshame/

Anyways found few links related to this finally block, Follow the below links for answers related to that. Does finally always execute in Java? Returning from a finally block in Java

Community
  • 1
  • 1
user3484262
  • 1