outside of foreach loop query doesn't work properly

Question

Here I'm trying to insert the datas again into database new table (with quantity & customer details). $grocery_id and $grocery_item values are fetch from database. $customername, $customermobile, $groqty values are user will enter the details in that appropriate textfield.

When I execute this code ($groceryid, $groceryitem) -> These two column always stored the last row values. Because I've put the query outside of foreach loop. Here is my problem. If I put the query inside the foreach it works fine. But, quantity values doesn't work properly. So, How can I execute the query properly (outside of foreach loop)?

<?php
    if(isset($_POST['submit']))
    {
        $grocery_id = $rowid;
        $grocery_item = $rowsitem;
        $customername = $_POST['customername'];
        $customermobile = $_POST['customermobile'];
        $groqty = $_POST['groceryquantity'];

        for($i = 0; $i < sizeof($groqty); $i++)
        {
            $groqtys = $groqty[$i];

            foreach($grocery_id as $key => $index_id )
            {           

            }       

            $sql = "INSERT INTO ".customer_order." SET grocery_id = '$index_id' , grocery_item = '$grocery_item[$key]', customername = '$customername', customermobile = '$customermobile', quantity = '$groqtys' ";
            mysql_query($sql,$CN);
            $response = asort_form_ok("Your order successfully submitted. We will deliver you soon.");
        }
    }
?>

enter image description here

Put both inside the `foreach` loop ? The `$groqtys` and your query. — iamsleepy, Apr 01 '14 at 09:39
@iamsleepy: I've tried. But quantity values stored multiple times??? — Karuppiah RK, Apr 01 '14 at 09:41
@RoyalBg : I want to insert all the values into db table. But, It inserted last row values only ALWAYS — Karuppiah RK, Apr 01 '14 at 09:42
@Learner if the keys are equal of both arrays, use one loop, and put the `$key` or `$i` whatever you use for key in the loop, for both array keys — Royal Bg, Apr 01 '14 at 09:44
With the present data, there's not enough to determine the number of values in each variable. Does your POST contain multiple values? If so , which and how many? Is the array `$grocery_id` equal to the number of POST values? — AyB, Apr 01 '14 at 09:45
@ICanHasCheezburger : Yes, POST contain multiple values and $grocery_id also equal to the POST values. — Karuppiah RK, Apr 01 '14 at 09:48
And is the number of `$groqtys` = number of `$grocery_item` ? — AyB, Apr 01 '14 at 09:51
Oh and I forgot, what about `$customername` and `$customermobile`. Is that an array or a single value? — AyB, Apr 01 '14 at 09:56

score 1 · Accepted Answer · edited May 25 '19 at 13:56

1

You could simply use one foreach loop considering the index values of $grocery_id and $groqty are the same.

Try:

<?php

if (isset($_POST['submit']))
    {
    $grocery_id = $rowid;
    $grocery_item = $rowsitem;

    // sanitizing your values
    $customername = mysql_real_escape_string($_POST['customername']);
    $customermobile = mysql_real_escape_string($_POST['customermobile']);
    $groqty = array_map('mysql_real_escape_string', $_POST['groceryquantity']);
    foreach($grocery_id as $key => $index_id)
       {
        $sql = "INSERT INTO " . customer_order . " SET grocery_id = '$index_id' , grocery_item = '$grocery_item[$key]', customername = '$customername', customermobile = '$customermobile', quantity = '$groqty[$key]' ";
        mysql_query($sql, $CN);
        $response = asort_form_ok("Your order successfully submitted. We will deliver you soon.");
       }

    }

?>

Also note:

Please, don't use mysql_* functions in new code. They are no longer maintained and are officially deprecated. See the red box? Learn about prepared statements instead, and use PDO, or MySQLi - this article will help you decide which. If you choose PDO, here is a good tutorial.

edited May 25 '19 at 13:56

Zoe

27,060
21
118
148

answered Apr 01 '14 at 10:00

AyB

11,609
4
32
47

but quantity column fields does not store into db? `$groqtys[$key]`? – Karuppiah RK Apr 01 '14 at 10:05
I have changed `$groqtys[$key]` into `$groqty[$key]` – Karuppiah RK Apr 01 '14 at 10:07
@Learner Ah sorry, didn't notice the difference. – AyB Apr 01 '14 at 10:08
Its ok. Thanks for spend some time to clear my doubts. I have already use PDO statements. But, my senior says use mysql. So, only i'm using mysql query – Karuppiah RK Apr 01 '14 at 10:09
@Learner God forbid if ever your database is hacked, blame it all on your senior then >:D – AyB Apr 01 '14 at 10:10

outside of foreach loop query doesn't work properly

1 Answers1