If-statement don't return value

Question

I am trying to make an if statement to change the value of 3 variables. The problem is that i don't get any value even if the condition is true:

here I get the string that I want to check:

    final String[] pos_categ ;
    pos_categ = intent1.getExtras().getStringArray("categ");

Here I implement the variables that i want to change:

    String[] title = null;
    String[] eng = null;
    final String[] dan = null;

Here is the if statement:

    if (pos_categ[0]==lessons_titles[0]){
        title[0] = lessons_titles[position[0]];
        eng[0] = eng_version[position[0]];
        dan[0] = dan_version[position[0]].toLowerCase();
    }
    if (pos_categ[0]==lessons_titles2[0]){
        title[0] = lessons_titles2[position[0]];
        eng[0] = eng_version2[position[0]];
        dan[0] = dan_version2[position[0]].toLowerCase();
    }
    if (pos_categ[0]==lessons_titles3[0]){
        title[0] = lessons_titles3[position[0]];
        eng[0] = eng_version3[position[0]];
        dan[0] = dan_version3[position[0]].toLowerCase();
    }
    if (pos_categ[0]==lessons_titles4[0]){
        title[0] = lessons_titles4[position[0]];
        eng[0] = eng_version4[position[0]];
        dan[0] = dan_version4[position[0]].toLowerCase();
    }
    if (pos_categ[0]==lessons_titles5[0]){
        title[0] = lessons_titles5[position[0]];
        eng[0] = eng_version5[position[0]];
        dan[0] = dan_version5[position[0]].toLowerCase();
    }
    if (pos_categ[0]==lessons_titles6[0]){
        title[0] = lessons_titles6[position[0]];
        eng[0] = eng_version6[position[0]];
        dan[0] = dan_version6[position[0]].toLowerCase();
    }

    title_view.setText(title[0]);
    eng_view.setText(eng[0]);
    dan_view.setText(dan[0]);

Can someone tell me where I've made a mistake ?

Where have you initialized values for title, eng, dan? – kAnNaN Apr 01 '14 at 11:49 — kAnNaN, Apr 01 '14 at 11:49
First thing: You should use else if instead of if – Andi Krusch Apr 01 '14 at 11:49 — Andi Krusch, Apr 01 '14 at 11:49

score 4 · Answer 1 · answered Apr 01 '14 at 11:49

4

In Java, use string.equals() to check string equality by content:

if (pos_categ[0].equals(lessons_titles[0])){
  ....
}

answered Apr 01 '14 at 11:49

Alex Salauyou

14,185
5
45
67

That's right! "string == string" compares the actual objects, not their string contents! – Andi Krusch Apr 01 '14 at 11:51
4

@AndiKrusch better say 'references' =) – Alex Salauyou Apr 01 '14 at 11:51

score 0 · Answer 2 · answered Apr 01 '14 at 11:52

0

use .equals for string dude like String1.equals(string2) when ever we use harcode string like "string" then == and .equals both are same but whenever we use string object then always use .equals

answered Apr 01 '14 at 11:52

Bhanu Sharma

5,135
2
24
49

score 0 · Answer 3 · answered Apr 01 '14 at 12:14

Use The Code Below:

if (pos_categ[0].equals(lessons_titles[0])){
            title[0] = lessons_titles[position[0]];
            eng[0] = eng_version[position[0]];
            dan[0] = dan_version[position[0]].toLowerCase();
        }
        if (pos_categ[0].equals(lessons_titles2[0])){
            title[0] = lessons_titles2[position[0]];
            eng[0] = eng_version2[position[0]];
            dan[0] = dan_version2[position[0]].toLowerCase();
        }
        if (pos_categ[0].equals(lessons_titles3[0])){
            title[0] = lessons_titles3[position[0]];
            eng[0] = eng_version3[position[0]];
            dan[0] = dan_version3[position[0]].toLowerCase();
        }
        if (pos_categ[0].equals(lessons_titles4[0])){
            title[0] = lessons_titles4[position[0]];
            eng[0] = eng_version4[position[0]];
            dan[0] = dan_version4[position[0]].toLowerCase();
        }
        if (pos_categ[0].equals(lessons_titles5[0])){
            title[0] = lessons_titles5[position[0]];
            eng[0] = eng_version5[position[0]];
            dan[0] = dan_version5[position[0]].toLowerCase();
        }
        if (pos_categ[0].equals(lessons_titles6[0])){
            title[0] = lessons_titles6[position[0]];
            eng[0] = eng_version6[position[0]];
            dan[0] = dan_version6[position[0]].toLowerCase();
        }

        title_view.setText(title[0]);
        eng_view.setText(eng[0]);
        dan_view.setText(dan[0]);

If-statement don't return value

3 Answers3