2

I am trying to replace all double commas with ,null,

The problem is that i need to keep doing it while it is replacing it. I am thinking about adding a loop but is there any other more eficient alternative?

var test = "[1,2,,,3,4,,,,,,5,6]".replace(/,{2}/g, ",null,");

alert(test);

The result should be: 

"[1,2,null,null,3,4,null,null,null,null,null,5,6]"

But is instead:

[1,2,null,,3,4,null,,null,,null,5,6]

So I would have to create a loop and do it until all double commas are done. Not sure if there is any other way?

As a side info, this is so that I can afterwards do:

var myArray = $.parseJSON(test);

Which currently it fails which I'm guessing that it's because it is not valid json.

  • Few solutions below, Using split and Join will be slower than using just regular expressions, if i'm not wrong. – vivek_nk Apr 02 '14 at 05:06
  • The commas could potentially be many more than this since it's user data and so performance is my main concern. –  Apr 02 '14 at 05:09
  • possible duplicate of [How can I match overlapping strings with regex?](http://stackoverflow.com/questions/20833295/how-can-i-match-overlapping-strings-with-regex) –  Apr 02 '14 at 05:12

6 Answers6

4

Single regex:

"[AB,,,CD,,,,,,EF]".replace(/,(?=,)/g, ',null');

demo

Here we use the ?= lookahead to find 2 commas ("comma with a comma after it") but match and replace only the first.

Edit:

You seem to be interested in speed, here are some tests.

Mosho
  • 7,099
  • 3
  • 34
  • 51
3
str.split(',').map(function(x) { return x ? x : 'null' }).join(',');

FIDDLE

splits the string by commas, then map() iterates and returns each value from the callback, and the ternary returns x (the value) if thruthy and the string 'null' if falsy, which an empty string is, then join it back together again.

adeneo
  • 312,895
  • 29
  • 395
  • 388
0

Not sure if regex could handle that without looping.

Alternative solution is to split is into an array: '1,2,,,3,4,,,,,,5,6'.split(','); and then loop through it and replace all empty strings with null and then join it back.

So, something like this: 

var s = '1,2,,,3,4,,,,,,5,6';
var a = s.split(',');
for (var i = 0; i < a.length; i++) {
    if (a[i] == "") {
        a[i] = "null";
    }
}
s = '[' + a.join(',') + ']';

See it here: http://jsfiddle.net/fVMLv/1/

Shomz
  • 37,421
  • 4
  • 57
  • 85
0

You can do this:

var test = "[1,2,,,3,4,,,,,,5,6]".split(',').join(',|').replace(/\|,/g,"null,");
alert(test.replace(/\|/g,""));

It alerts:

[1,2,null,null,3,4,null,null,null,null,null,5,6]

Demo: http://jsfiddle.net/AmitJoki/Zuv38/

Amit Joki
  • 58,320
  • 7
  • 77
  • 95
0

Try this

var str = "1,2,,,3,4,,,,,,5,6";
str = str.split(',');
var strResult ='';
$(str).each(function(){
    if(this==''){
        strResult +='null,';
    }
    else{
        strResult +=this+',';
    }
});
strResult = strResult.substring(0,strResult.length-1);
alert(strResult);

DEMO

nrsharma
  • 2,532
  • 3
  • 20
  • 36
0

The problem is with the double commas occurring consecutively. ,,,, -> will be taken as 2 sets of double commas by that RegExp. So, result will be:- ,null,,null, -> note that the occurrence of another double comma in between is skipped, since the RegEx is greedy (2nd comma is already used, which is not used again together with 3rd comma. rather 3rd and 4th are used together).

var test = "[AB,,,CD,,,,,,EF]".replace(/,,/g, ",null,").replace(/,,/g, ",null,");
alert(test);

So, with this RegExp, calling it twice will fix this.

vivek_nk
  • 1,590
  • 16
  • 27
  • This actually works perfectly no matter how many commas there are which at first glance I thought I would need many more replaces as commas available. This also avoids creating a while loop with just 2 replaces. very nice indeed. I need to test performance since this is critical aspect of this question to me as I have an idea that regex will be faster than iterations or splits. –  Apr 02 '14 at 05:16