stream.copyto with progress bar reporting

Question

i want to merge 2 large files but atm my code only updates the progress after 1 file is copied is there a better way to report progress this is my copy code atm

 max = files.Count;
 MessageBox.Show("Merge Started");
 using (Stream output = File.OpenWrite(dest))
   {
      foreach (string inputFile in files)
        {
          using (Stream input = File.OpenRead(inputFile))
            {
              input.CopyTo(output);
              count++;
              progress = count * 100 / max;
              backgroundWorker2.ReportProgress(Convert.ToInt32(progress));
            }
        }
  }
MessageBox.Show("Merge Complete");

score 9 · Accepted Answer · edited Jan 28 '16 at 16:41

9

You could read the file in chunks.

You should notify the BackgroundWorker in between.

using (Stream output = File.OpenWrite(dest))
{
    foreach (string inputFile in files)
    {
        using (Stream input = File.OpenRead(inputFile))
        {
            byte[] buffer = new byte[16 * 1024];

            int read;
            while ((read = input.Read(buffer, 0, buffer.Length)) > 0)
            {
                output.Write(buffer, 0, read);

                // report progress back
                progress = (count / max + read / buffer.Length /* part of this file */) *  100;
                backgroundWorker2.ReportProgress(Convert.ToInt32(progress));
            }

            count++;
            progress = count * 100 / max;
            backgroundWorker2.ReportProgress(Convert.ToInt32(progress));
        }
    }
}

edited Jan 28 '16 at 16:41

Community

1
1

answered Apr 04 '14 at 09:00

Patrick Hofman

153,850
22
249
325

its not working seizing up the app probaly cause im trying to merge 4 2gb files to make 1 8 gb file – outlaw1994 Apr 04 '14 at 09:08
@outlaw1994: I merged your code and mine. Check it out. – Patrick Hofman Apr 04 '14 at 09:13
thanks tested it and they merge fine and actually faster than my last code but the progress goes to 100% straight away anyway to fix this also had to change ms to output – outlaw1994 Apr 04 '14 at 09:25
Feel free to add it as an answer for future users. – Patrick Hofman Apr 04 '14 at 10:29

score 3 · Answer 2 · answered Apr 05 '14 at 00:43

this is the code i ended up using thanks patrick for helping a lot

            List<string> files = new List<string>();
            if (file1 != null && file2 != null)
            {
                files.Add(file1);
                files.Add(file2);
            }
            if (file3 != null)
            {
                files.Add(file3);
            }
            if (file4 != null)
            {
                files.Add(file4);
            }
                    max = files.Count;
                    MessageBox.Show("Merge Started");
                    using (Stream output = File.OpenWrite(dest))
                    {
                        foreach (string inputFile in files)
                        {
                            using (Stream input = File.OpenRead(inputFile))
                            {
                                byte[] buffer = new byte[32 * 1024];
                                int read;
                                while ((read = input.Read(buffer, 0, buffer.Length)) > 0)
                                {
                                    output.Write(buffer, 0, read);
                                    count++;
                                    // report progress back
                                    progress = count * 100 / read;
                                    backgroundWorker2.ReportProgress(Convert.ToInt32(progress));
                                }
                            }
                        }
                    }
                    MessageBox.Show("Merge Complete");

stream.copyto with progress bar reporting

2 Answers2

Linked