I am having trouble making my contact form send

Question

This form code will not send emails...

This is the HTML Form:

<form method="post" action="index.php">
        <table class="form">
            <tr>
                <th class="label">
                    <label for="name">Name</label>
                </th>

                <td class="input">
                    <input type="text" name="name" id="name">
                </td>
            </tr>

            <tr>
                <th class="label">
                    <label for="email">Email</label>
                </th>

                <td class="input">
                    <input type="text" name="email" id="email">
                </td>
            </tr>

            <tr>
                <th class="label">
                    <label for="message">Message</label>
                </th>

                <td class="input">
                    <textarea type="text" name="message" id="message"></textarea>
                </td>
            </tr>
        </table>

        <input type="submit" value="Send">
    </form>

Here is the send code:

<?php 

if ($_SERVER["REQUEST_METHOD"] == "POST") {

$name = $_POST["name"];
$email = $_POST["email"];
$message = $_POST["message"];
$email_body = "";

$email_body = $email_body . "Name: " . $name;
$email_body = $email_body . "Email: " . $email;
$email_body = $email_body . "Message: " . $message;

mail("myemail@email.com" , "Contact Form" ,  $message , "From: $name");

header("Location: index.php?formsubmit=1");

exit;
}

?>

I'm not at all sure what is wrong, it worked before, but after I tried adding some things to my code, like a thing that said if form submit is equal to one display thanks for contacting us instead of explaining the form. That should not have anything to do with it though, I wouldn't think...

Could it be the fact that I added the whole ?formsubmit=1 thing?

Thanks for any help.

Step one: [Enable error reporting](http://stackoverflow.com/a/6575502/1438393). — Amal Murali, Apr 05 '14 at 14:10
Add some error reporting code as suggested by Amal so that you'd know where the error has occured ?! — Magesh Kumaar, Apr 05 '14 at 14:10
@Hunter: PHP Error Reporting: http://www.php.net/manual/en/function.error-reporting.php — Pete Scott, Apr 05 '14 at 14:12
I got this error. Warning: Cannot modify header information - headers already sent by (output started at /home/PATHPART/public_html/PATHPART/BLAH/index.php:5) in /home/PATHPART/public_html/PATHPART/BLAH/index.php on line 20 — Hunter, Apr 05 '14 at 14:17
Your script is open to header injection, also you do noting with `$email_body`... — Lawrence Cherone, Apr 05 '14 at 14:20

benomatis · Answer 1 · 2014-04-05T20:09:17.627

Make sure that you only set Location in header if you haven't put any code in front that would output any visible information (ie. echo, print_r...). Ideally header should be at the beginning of your page, before anything is 'printed'.

As explained in the PHP manual: PHP: header - Manual

Remember that header() must be called before any actual output is sent, either by normal HTML tags, blank lines in a file, or from PHP. It is a very common error to read code with include, or require, functions, or another file access function, and have spaces or empty lines that are output before header() is called.

A common practice, though, to verify if a form has been submitted is to name you submit button like this...

<input name="submit" type="submit" value="Send" />
<!-- I added the 'name' attribute here -->

and check it like this (in your 'send' code, as you called it)...

if (isset($_POST['submit'])) {
    // same index as the 'name' attribute above
}

score 0 · Answer 2 · answered Apr 05 '14 at 14:28

I figured it out myself,

<form method="post" action="index.php?formsubmit=1">

is what I needed, got rid of the

header("Location: index.php?formsubmit=1");

and stuck

<?php 

if ($_SERVER["REQUEST_METHOD"] == "POST") {

$name = $_POST["name"];
$email = $_POST["email"];
$message = $_POST["message"];
$email_body = "";

$email_body = $email_body . "Name: " . $name;
$email_body = $email_body . "Email: " . $email;
$email_body = $email_body . "Message: " . $message;

mail("jiggaboojones@gmail.com" , "Contact Form" ,  $message , "From: $name");

exit;
}

?>

At the bottom.

Thanks

I am having trouble making my contact form send

2 Answers2