c# can't get attributes out of xml

Question

I have a problem where im trying to get the values from the attributes of a xml file from a url.

xml: http://thegamesdb.net/api/GetGamesList.php?name=x-men

code:

public MainPage()
    {
        InitializeComponent();

        var webClient = new WebClient();
        webClient.DownloadStringCompleted += RequestCompleted;
        webClient.DownloadStringAsync(new     Uri("http://thegamesdb.net/api/GetGamesList.php?name=x-men"));
    }

    private void RequestCompleted(object sender, DownloadStringCompletedEventArgs e)
    {
        if (e.Error == null)
        {
            var feedXml = XDocument.Parse(e.Result);

            var gameData = feedXml.Root.Elements("Game").Select(x => new GetGamesList
              {
// ERROR VALUES ARE NULL
                  ID = (int)x.Attribute("id"), 
                  GameTitle = (string)x.Attribute("GameTitle"),
                  ReleaseDate = (string)x.Attribute("ReleaseDate"),
                  Platform = (string)x.Attribute("Platform")
              })
              .ToList();
        }
    }

public class GetGamesList
{
    public int ID { get; set; }
    public string GameTitle { get; set; }
    public string ReleaseDate { get; set; }
    public string Platform { get; set; }
}

I hope there is someone that can help me, thanks.

Are you trying to get just one element? – bubbinator Apr 06 '14 at 13:34 — bubbinator, Apr 06 '14 at 13:34
Yes right now im just trying to get one of the element. – Thunder Apr 06 '14 at 13:36 — Thunder, Apr 06 '14 at 13:36

score 0 · Accepted Answer · answered Apr 06 '14 at 13:36

0

id, GameTitle, ReleaseDate and Platform are all elements under Game, viz:

  ID = int.Parse(x.Element("id")), 
  GameTitle = (string)x.Element("GameTitle"),
  ReleaseDate = (string)x.Element("ReleaseDate"),
  Platform = (string)x.Element("Platform")

You'll also need to parse the int.

answered Apr 06 '14 at 13:36

StuartLC

104,537
17
209
285

Yes it works. Thanks. But i thought was a "Element" and was a "Attribute" ?, – Thunder Apr 06 '14 at 13:41
Attributes in xml are on the element, in quotes, e.g. your code would parse xml like this : `` – StuartLC Apr 06 '14 at 13:43
Thanks, but when is it a attribute in a xml file? – Thunder Apr 06 '14 at 13:47

bubbinator · Answer 2 · 2014-04-06T14:19:08.897

You need FirstOrDefault instead of Select. Try this in place of Select:

.FirstOrDefault(e => e.Attribute("id") == "665")

Just replace the 665 portion with the id# you want.

EDIT: in looking at StuartLC's answer and the provided xml file. I overlooked the simple design that you used. The data that you are trying to get are indeed elements, not attributes. So you would need to replace the Attribute call to Element like so:

.FirstOrDefault(e => e.Element("id") == "665")

On a side note, the return value of Elements is an IEnumerable<XElement> which allows you to iterate over the values within it.

EDIT: This will return the XElement containing the desired data. At this point, you can use StuartLC's answer to transfer the data into your class.

c# can't get attributes out of xml

2 Answers2