Loading from URL not working

Question

I'm trying to load an image (JPG) from a url using the following asynctask method.

private class DownloadImageTask extends AsyncTask<String, Void, Bitmap> {
        ImageView bmImage;

        public DownloadImageTask(ImageView bmImage) {
            this.bmImage = bmImage;
        }

        protected Bitmap doInBackground(String... urls) {
            String urldisplay = urls[0];
            Bitmap mIcon11 = null;
            try {
                InputStream in = new java.net.URL(urldisplay).openStream();
                mIcon11 = BitmapFactory.decodeStream(in);
            } catch (Exception e) {
                Log.e("Error", e.getMessage());
                e.printStackTrace();
            }
            return mIcon11;
        }

        protected void onPostExecute(Bitmap result) {
            bmImage.setImageBitmap(result);
        }
    }

I'm executing this method in onCreate like this

new DownloadImageTask((ImageView) findViewById(R.id.imageView1)).execute(final_url);

But I can't see any image and when I debugged it, I found the value of mIcon11 to be null. What am I doing wrong

PS : The final_url goes like this

www.website.com/somelink/IMG 005_153.JPG

btw you have to encode your url because it has a space ;), Where are you executing this? in onCreate? Try to init your ImageView in oncreate and store it as global value in your activity and pass it to your task — A.S., Apr 09 '14 at 11:13

Systematix Infotech · Answer 1 · 2014-04-09T11:23:50.160

0

Your finalurlhttp://www.website.com/somelink/IMG%20005_153.JPG is not returning any thing. Check that..

Try to encode it before using it.

String uri = Uri.parse("http://...")
            .buildUpon()
            .appendQueryParameter("key", "val")
            .build().toString();

or try following

String uri = URLEncoder.encode(finalurl, "utf-8");

edited Apr 09 '14 at 11:23

answered Apr 09 '14 at 11:12

Systematix Infotech

2,345
1
14
31

That is not the actual link. The actual link is http://gateway.ceylonlinux.com/CL_GOLD/view/add_product/upload/BAE 005_153.JPG The link works – user2028405 Apr 09 '14 at 11:14
that's still no accessible, try some general url first, say from google images and see if it works, then check yours. – Saqib Apr 09 '14 at 11:16
1

The problem is that your url need to be encoded before sending its request. – Systematix Infotech Apr 09 '14 at 11:18
A general link works. Guess I'll have to encode the url. Can you tell me how to? – user2028405 Apr 09 '14 at 11:21
I have added that in my answered please take a look – Systematix Infotech Apr 09 '14 at 11:22

score 0 · Answer 2 · answered Apr 09 '14 at 11:34

private class ImageLoadTask extends AsyncTask<String, Void, Bitmap> {
        private Bitmap bitmap;

        @Override
        protected void onPreExecute() {
            // TODO Auto-generated method stub
            pb1.setVisibility(View.VISIBLE);
            super.onPreExecute();
        }

        @Override
        protected Bitmap doInBackground(String... params) {

            // TODO Auto-generated method stub
            try {
                URL url;
                url = new URL(params[0]);
                HttpURLConnection connection = (HttpURLConnection) url
                        .openConnection();
                connection.setDoInput(true);
                connection.connect();
                InputStream input = connection.getInputStream();
                bitmap = BitmapFactory.decodeStream(input);
            } catch (MalformedURLException e) {
                // TODO Auto-generated catch block
                e.printStackTrace();
            } catch (IOException e) {
                // TODO Auto-generated catch block
                e.printStackTrace();

            }
            return bitmap;
        }

        @Override
        protected void onPostExecute(Bitmap result) {
            // TODO Auto-generated method stub
            super.onPostExecute(result);
            im.setImageBitmap(result);
            pb1.setVisibility(View.INVISIBLE);
        }
    }

and call it like

new ImageLoadTask().execute(STRING URL);

Loading from URL not working

2 Answers2