C char not working in if..else

Question

When I run the program no matter what I enter for shape, the final else statement is executed.

#include <stdio.h>

int main(void)
{
    char shape = 'a';
    printf("What shape do you want?\nEnter 's' for a Square, 'b' for a Box, 't' for a Triangle\n");

    while (shape != 's' && shape != 'b' && shape != 't')
    {
        scanf_s(" %c", &shape);

        if (shape == 's')
        {
            printf("You entered %c", shape);
        }

        else if (shape == 'b')
        {
            printf("You entered %c", shape);
        }

        else if (shape == 't')
        {
            printf("you entered %c", shape);
        }

        else
        {
            printf("Please enter 's' 'b' or 't'");
        }
    }
    return 0;
}

try removing the leading space on the format string. scanf_s is not a good choice for reading a single character. getchar is probably a better choice. — Hogan, Apr 12 '14 at 01:49
I don't know `C`, but `scanf_s(" %c", &shape);` is not capturing the input. BTW, your `while` will always be true. — yizzlez, Apr 12 '14 at 01:49
@user3525735 : [Please avoid anything which is related to chating inside posts and comments](http://meta.stackexchange.com/a/3021/242800) (this include thanks and please...). — user2284570, Apr 12 '14 at 02:35

score 0 · Answer 1 · answered Apr 12 '14 at 01:55

0

You appear to have a space character in parameter 1.

scanf_s(" %c", &shape);

answered Apr 12 '14 at 01:55

Steve K

643
6
8

score 0 · Accepted Answer · answered Apr 12 '14 at 01:56

0

scanf_s requires the number of chars you want to read (hence the _s). Try scanf(" %c", &shape, 1).

answered Apr 12 '14 at 01:56

ooga

15,423
2
20
21

score 0 · Answer 3 · answered Apr 12 '14 at 01:59

0

Replace scanf_s(" %c", &shape); with either scanf_s(" %c", &shape, (size_t)1); or scanf(" %c", &shape);. You did not provide enough arguments.

answered Apr 12 '14 at 01:59

Deduplicator

44,692
7
66
118

C char not working in if..else

3 Answers3