Cell text overlapping when scrolling in UITableView Xcode iOS

Question

Everytime I start scrolling in the tableView the subtitleLabel text keeps overlapping each other in every row. I've tried for the last 4 hours every single search on the Internet for this problem I have clicked and tried.

Here is my ViewController.m:

@interface ANViewController()
{

    NSMutableArray *TitleLabel;
    NSMutableArray *SubtitleLabel;
    NSMutableArray *AvatarImages;

}

@end


@implementation ANViewController

@synthesize thetableview;

- (void)viewDidLoad
{
    [super viewDidLoad];

    self.thetableview.delegate = self;
    self.thetableview.dataSource = self;

    TitleLabel = [NSMutableArray array];
    SubtitleLabel = [NSMutableArray array];
    AvatarImages = [NSMutableArray array];

    __block NSArray *posts;

    __block NSData *allNewsData = nil;

    dispatch_queue_t queue = dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_BACKGROUND, 0ul);
    dispatch_async(queue, ^{
        allNewsData = [NSData dataWithContentsOfURL:[NSURL URLWithString: API_URL]];
        NSError *error;
        NSMutableDictionary *allNews = [NSJSONSerialization JSONObjectWithData:allNewsData options:NSJSONReadingMutableContainers error:&error];
        if (error) {
            NSLog(@"%@", [error localizedDescription]);
        } else {
            posts = allNews[@"data"];
            for (NSDictionary *newsPost in posts) {
                [TitleLabel addObject:newsPost[@"title"]];
                [SubtitleLabel addObject:newsPost[@"post_message"]];
                NSString *avatarUrl = AVATAR_URL;
                NSString *avatarExt = @".jpg";
                [AvatarImages addObject:[NSString stringWithFormat:@"%@%@%@", avatarUrl, newsPost[@"user_id"], avatarExt]];
            }
        }
        dispatch_sync(dispatch_get_main_queue(), ^{
            NSLog(@"THIS IS THE MAIN THREAD...");
            [self.thetableview reloadData];
        });
    });

    NSURL *url = [NSURL URLWithString: WEBSITE_URL];
    NSURLRequest *urlRequest = [NSURLRequest requestWithURL:url];
    [webView loadRequest:urlRequest];
}

-(NSInteger)numberOfSectionsInTableView:(UITableView *)tableView
{
    return 1;
}

-(NSInteger)tableView:(UITableView *)tableView numberOfRowsInSection:(NSInteger)section
{
    long count = TitleLabel.count;
    if(count == 0){
        count = 1;
    }
    return count;
}

-(UITableViewCell *)tableView:(UITableView *)tableView cellForRowAtIndexPath:(NSIndexPath *)indexPath
{
    NSString *CellIdentifier;
    ANTableViewCell *Cell;
    if(TitleLabel.count == 0){
        NSLog(@"Did with no news");
        CellIdentifier = @"Cell_NoNews";
        Cell = [thetableview dequeueReusableCellWithIdentifier:CellIdentifier];
        if (Cell == nil) {
            Cell = [[ANTableViewCell alloc] initWithStyle:UITableViewCellStyleDefault reuseIdentifier:CellIdentifier];
        }
        Cell.noNewsLabel.text = @"No news to display!";
    }else{
        NSLog(@"Did with news");
        CellIdentifier = @"Cell";
        Cell = [thetableview dequeueReusableCellWithIdentifier:CellIdentifier];
        if (Cell == nil) {
            Cell = [[ANTableViewCell alloc] initWithStyle:UITableViewCellStyleDefault reuseIdentifier:CellIdentifier];
        }

        Cell.TitleLabel.text = [TitleLabel objectAtIndex:indexPath.row];
        Cell.SubtitleLabel.text = [SubtitleLabel objectAtIndex:indexPath.row];

        NSURL *url = [NSURL URLWithString:[AvatarImages objectAtIndex:indexPath.row]];
        NSData *data = [NSData dataWithContentsOfURL:url];
        UIImage *img = [[UIImage alloc] initWithData:data];
        Cell.AvatarImage.image = img;
    }

    return Cell;
}

- (void)didReceiveMemoryWarning
{
    [super didReceiveMemoryWarning];
}

@end

neowinston · Accepted Answer · 2014-04-14T18:23:03.230

0

Just change UITableViewCellStyleSubtitle for UITableViewCellStyleDefault, and you need an asynchronous connection instead of a synchronous like you're doing: NSData *allNewsData = [[NSData alloc] initWithContentsOfURL: [NSURL URLWithString:API_URL]]; in your viewDidLoad method that is blocking your main thread.

You can adapt this code to your need, in order to download it on the background:

__block NSData *allNewsData = nil;

dispatch_queue_t queue = dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0);
dispatch_async(queue, ^{
    allNewsData = [NSData dataWithContentsOfURL:[NSURL URLWithString: API_URL]];
NSURL *url = [NSURL URLWithString: WEBSITE_URL];
NSURLRequest *urlRequest = [NSURLRequest requestWithURL:url];
[webView loadRequest:urlRequest];
    dispatch_sync(dispatch_get_main_queue(), ^{
        NSLog(@"THIS IS THE MAIN THREAD...");
        [self.thetableview reloadData];
    });
});

edited Apr 14 '14 at 18:23

answered Apr 14 '14 at 02:55

neowinston

7,584
10
52
83

Try increasing the row height to see what happens. – neowinston Apr 14 '14 at 03:00
Where is that? I dont see it. – user3530391 Apr 14 '14 at 03:01
On your Storyboard or xib file. – neowinston Apr 14 '14 at 03:03
Still the same issue. – user3530391 Apr 14 '14 at 03:05
Why do you [Cell removeFromSuperview]; ? Try removing this line. – neowinston Apr 14 '14 at 03:09
Oh that was there for testing, I removed it in the new code I just updated. – user3530391 Apr 14 '14 at 03:11
Try to hard code the subtitle to see if it still happens, like this cell.detailTextLabel.text=@"subTible..."; – neowinston Apr 14 '14 at 03:18
I ended up just making 15 of the same prototype cells and using a different name for each, and that works. – user3530391 Apr 14 '14 at 03:26
You know what, actually thats just a bitch way to get out of this problem. im going to solve this the right way. – user3530391 Apr 14 '14 at 03:31
Yes, keep working on the problem because all hacks that we make to solve problems on the short run will return to bite us in the future. – neowinston Apr 14 '14 at 03:33
Ok so it seems when I hardcode it the issue goes away. – user3530391 Apr 14 '14 at 03:33
Yes, then the issue seems to be on the way you're getting your data from. – neowinston Apr 14 '14 at 03:34
So what can I do to fix it? – user3530391 Apr 14 '14 at 03:35
I think the problem is NSData *allNewsData = [[NSData alloc] initWithContentsOfURL: [NSURL URLWithString:API_URL]]; because it's a synchronous connection. You need an asynchronous connection on the background. See this http://stackoverflow.com/questions/8515667/how-to-send-asynchronous-url-request – neowinston Apr 14 '14 at 03:37
Now I see that you're blocking the main thread, and that's why you're having this issue. – neowinston Apr 14 '14 at 03:42
What do I do to fix it then? – user3530391 Apr 14 '14 at 03:43
All User Interface related stuff runs on the main thread, so if you're making a download on it you'll block the User Interface.Try modifying the code I'll put on my answer. – neowinston Apr 14 '14 at 03:52
You have to use __block NSData *allNewsData = nil; – neowinston Apr 14 '14 at 04:03
I get this error in console now when trying to load the app now: `Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 'data parameter is nil'` – user3530391 Apr 14 '14 at 04:04
You need to rearrange the code to make it happen in the proper order so you pass the data only when it's ready. Sorry, but I need to go now. I hope you can fix it now and tomorrow I can try to help you more if you don't. – neowinston Apr 14 '14 at 04:08
I still haven't been able to make it work no :/ The app doesn't start and it gives a console error of ` *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 'data parameter is nil'` – user3530391 Apr 14 '14 at 16:05
Ok so I was able to get it all working, and the issue is still happening. I updated the code in my post with the latest code. – user3530391 Apr 14 '14 at 16:42
Still doesnt work, btw that webView is for something else not the table view. – user3530391 Apr 14 '14 at 17:43
I just ended up making the background of the label white, and it doesn't show the overlapping text anymore. Its the only thing I can do at this point. I still accepted your answer for the help. Thanks :). – user3530391 Apr 14 '14 at 22:46
Thanks for accepting the answer. I had fun trying to solve the problem with you. Sometimes it's just like that, and we only find the best solution after a while. I hope you have a great success with your project. – neowinston Apr 15 '14 at 00:07

Cell text overlapping when scrolling in UITableView Xcode iOS

1 Answers1