Python lottery game

Question

This is one of my first projects done entirely on my own without any tutorial and I am sure it is a little sloppy. Right now, I cannot figure out why my payout is always output as the payout for a 'box' type bet. I also haven't completely figured out how to represent the box type bets for 5 digit numbers, so that part of the program is not written yet. Any help or advice on fixing the betType?

#lotto program

#Created 04/14/2014, last modified 04/16/14
#4/16/14 made lottery a class, added 4 or 5 digit support
#4/16/14 added support for box type bets, now program assumes all payouts are for box type bets --UNRESOLVED
from random import *
import time



class Lottery:
def __init__(self, digits, betType, betAmt):
    self.digits = digits
    self.betType = betType
    self.betAmt = betAmt

def winner(self, tries, choice, betType):
    if self.betType.upper() == 'STRAIGHT' or 'S':
        if self.digits == '3':
            if self.betAmt == '1.00':
                payout = 500
            elif self.betAmt == '0.50':
                payout = 250
        elif self.digits == '4':
            if self.betAmt == '1.00':
                payout = 5000
            elif self.betAmt == '0.50':
                payout = 2500
        elif self.digits == '5':
            if self.betAmt == '1.00':
                payout = 50000
            elif self.betAmt == '0.50':
                payout = 25000

#At present I have not figured out how to add payouts for box type bets -- 4/16/2014
    if self.betType.upper() == 'BOX' or 'BOXED' or 'B':
        if self.digits == '3':
            if self.betAmt == '1.00':
                if len(set(choice)) == 3: # 6 way box
                    payout = 83
                elif len(set(choice)) == 2: # 3 way box
                    payout = 167
            elif self.betAmt == '0.50': 
                if len(set(choice)) == 3: # 6 way box
                    payout = 41.5
                elif len(set(choice)) == 2: # 3 way box
                    payout = 83.5
        elif self.digits == '4':
            if self.betAmt == '1.00':
                if len(set(choice)) == 4: #24 way box
                    payout = 200
                elif len(set(choice)) == 3: #12 way box
                    payout = 400
                elif len(set(choice)) == 2:
                    if sorted(choice)[0] == sorted(choice)[1] == sorted(choice)[2]: # 4 way box
                        payout = 1198
                    else: # 6 way box
                        payout = 800 
            elif self.betAmt == '0.50':
                if len(set(choice)) == 4: #24 way box
                    payout = 100
                elif len(set(choice)) == 3: #12 way box
                    payout = 200
                elif len(set(choice)) == 2:
                    if sorted(choice)[0] == sorted(choice)[1] == sorted(choice)[2]: # 4 way box
                        payout = 599
                    else: # 6 way box
                        payout = 400
        elif self.digits == '5':
            if self.betAmt == '1.00':
                if len(set(choice)) == 5: # 120 way box
                    payout = 417
                elif len(set(choice)) == 4: # 60 way box
                    payout = 834
                elif len(set(choice)) == 3: # Still working on all 5 digit box payouts
                    if sorted(choice)[0] == sorted(choice)[1]:
                        pass
            elif self.betAmt == '0.50':
                payout = 25000

    print "-----" * 10
    print "winner after " + str(tries) + " tries!"
    print "It took you " + str(tries/2) + " days to win!"
    print "your tickets cost $" + str(tries * float(self.betAmt)) + ".00"
    print "Your payout was $" + str(payout) + ".00"
    print "Your Net Revenue was $" + str(payout - tries) + ".00"
    print "-----" * 10


def play(self):
    print "<>" * 40
    print "Use 'mp' to play the same 'machine pick' each time"
    print "Use 'ap' to play a new 'machine pick' number each time"
    print "<>" * 40
    guess = raw_input("Choose a lottery number and see how long it takes until you win! >>")
    if guess.upper() == 'MP': #added machine pick option
        if self.digits == '3': #attempt support for 4 and 5 digit numbers
            choice = str(randint(0,9)) + str(randint(0,9)) + str(randint(0,9))
        elif self.digits == '4':
            choice = str(randint(0,9)) + str(randint(0,9)) + str(randint(0,9)) + str(randint(0,9))
        elif self.digits == '5':
            choice = str(randint(0,9)) + str(randint(0,9)) + str(randint(0,9)) + str(randint(0,9)) + str(randint(0,9))
        else:
            pass
    elif guess.upper() == 'AP': #placeholder for autopick in main loop
        pass
    else:
        choice = guess
    tries = 0
    while True:
        if guess.upper() == 'AP': #added machine pick option
            if self.digits == '3': #attempt support for 4 and 5 digit numbers
                choice = str(randint(0,9)) + str(randint(0,9)) + str(randint(0,9))
            elif self.digits == '4':
                choice = str(randint(0,9)) + str(randint(0,9)) + str(randint(0,9)) + str(randint(0,9))
            elif self.digits == '5':
                choice = str(randint(0,9)) + str(randint(0,9)) + str(randint(0,9)) + str(randint(0,9)) + str(randint(0,9))
        if self.digits == '3': #attempt support for 4 and 5 digit numbers
            winning = str(randint(0,9)) + str(randint(0,9)) + str(randint(0,9))
        elif self.digits == '4':
            winning = str(randint(0,9)) + str(randint(0,9)) + str(randint(0,9)) + str(randint(0,9))
        elif self.digits == '5':
            winning = str(randint(0,9)) + str(randint(0,9)) + str(randint(0,9)) + str(randint(0,9)) + str(randint(0,9))
        print winning, choice
        tries += 1
        if self.digits == '3':
            time.sleep(0.02)
        elif self.digits == '4':
            time.sleep(0.002)
        else:
            time.sleep(0.0005)
        if self.betType.upper() == 'STRAIGHT':
            if winning == choice:
                self.winner(tries, choice, self.betType)
                break
        elif self.betType.upper() == 'BOXED' or 'BOX':
            if sorted(winning) == sorted(choice):
                self.winner(tries, choice, self.betType)
                break
class Menu:
def __init__(self):
    #self.game = Lottery(digits, betType, betAmt)
    self.start()
def start(self):
    print "Welcome to the Lottery!"
    self.digits = raw_input("Would you like to play '3' digit, '4' digit, or '5' digit? >> ")
    self.betType = raw_input("Straight, or Boxed bet type? >> ")
    self.betAmt = raw_input("$0.50, or $1.00? >> ")
    self.game = Lottery(self.digits, self.betType, self.betAmt)
    self.game.play()
    raw_input("Enter to play again")

Menu1 = Menu()
#game = Lottery(digits, betType, betAmt)
if __name__ == '__main__':
while True:
    Menu1.start()

Cory Kramer · Answer 1 · 2014-04-17T19:52:33.293

4

This

if self.betType.upper() == 'BOX' or 'BOXED' or 'B'

Does not equal

if (self.betType.upper() == 'BOX') or (self.betType.upper() == 'BOXED') or (self.betType.upper() =='B')

The first will evaluate three different expressions:

if (self.betType.upper() == 'BOX')   # either True or False
if ('BOXED')  # this will ALWAYS evaluate to True
if ('B')     # this will also always evaluate to True

So if you or these together, you will always get true. You have to write out a full comparison to each string like the second method.

edited Apr 17 '14 at 19:52

answered Apr 17 '14 at 19:47

Cory Kramer

114,268
16
167
218

Quick, one imaginary brownie point to someone who can monkey hack `if 'B'` to fail! – Adam Smith Apr 17 '14 at 19:53
`def __bool__(self): return false` – Cory Kramer Apr 17 '14 at 19:56
Nope :(, at least not on Python3, you'd have to override `str.__bool__` which is impossible. – Adam Smith Apr 17 '14 at 19:56
I think you'd have to put this function in Python's `String` class, because with the literal `'B'` I can't think of a way. I tried redefining `def if(val)` but it yelled at me :/ – Cory Kramer Apr 17 '14 at 20:01

score 0 · Accepted Answer · answered Apr 17 '14 at 19:48

Python comparisons don't behave in the way you think they do:

 if self.betType.upper() == 'STRAIGHT' or 'S':

is equivalent to

if (self.betType.upper() == 'STRAIGHT') or ('S')

'S' is a non-zero entity so it evaluates to True - you can try:

if 'S':
    print('huh?')

As a general comment on the rest of your code: you don't need to encode the number of digits the player is using as a string value - it's better if self.digits is a number, as it allows for more Pythonic expressions - see if you can dynamically change choice based on the value of digits without using separate if statements. (As a hint, investigate "list comprehension")

Happy coding!

That was indeed the problem. Thanks a lot for the other suggestions too :) I'll try my best — user3543047, Apr 17 '14 at 20:06

Python lottery game

2 Answers2