syntax error on php file add to cart

Question

I'm getting various errors (syntax) on the following php file. The current php file is about onlineshops product-to-cart adding function. I get various errors. The errors start from the first echo and are listed as syntax error, unexpected 'echo'.

If I remove it, I get a syntax error, unexpected ';' on the next line.

Any help will be great. Thanks.

/* display cart */

if ( isset( $_SESSION['cart'] ) )
        (
        echo "<table border=0 cellspacing=0 cellpadding=0 width='500'>";
        $total = 0;
        foreach($_SESSION['cart'] as $id => $x)
        (
        $result = mysql_query("SELECT * from onlineshop WHERE id=$id",$db);
        $myrow = mysql_fetch_array($result);     
        $name = $myrow['name'];
        $name = substr($name,0,40);
        $price = $myrow['price'];
        $line_cost = $price *  $x;
        $total = $total + $line_cost;

         echo "<tr>";
         echo "<td allign='left'> $name </td>";
         echo "<td align = 'right'>X $x <a href='cart.php?id=".$id."&action=remove'> reduce </a></td>";
         echo "<td align = 'right'>= $line_cost £";
         echo "</tr>";
        )
        echo "<tr>";
        echo "<td align ='right'><br>Total=</td>";
        echo "<td align ='right'><b><br> $total £</b></td>";
        echo "</tr>";
        echo "</table>";
    )
    else
        echo "Cart is empty";

`if` and `else` use curly braces `{` `}` for their bodies not parenthesis `(` `)` same in `for` — Logan Murphy, Apr 21 '14 at 18:10
A definite déjà vue. Where have I seen this earlier? @JohnConde ;-) — Funk Forty Niner, Apr 21 '14 at 18:15
Kinda weird. Haven't seen this error in a while then two practically on top of each other. Must be that kind of day. — John Conde, Apr 21 '14 at 18:16
Maybe Easter Monday has that affect (*on some*). An Easter favorite probably. The rounded parts in the brackets makes them think of Easter Eggs. — Funk Forty Niner, Apr 21 '14 at 18:16
I manage to fix everything but I get this error on line -- $result = mysql_query("SELECT * from onlineshop WHERE id=$id",$con); -- the error message is * mysql_query() expects parameter 2 to be resource * — cmario, Apr 21 '14 at 18:25

score 1 · Accepted Answer · answered Apr 21 '14 at 18:11

You use wrong braces. Replace () with {} in if statement and foreach loop :

if (isset($_SESSION['cart'])){
    echo "<table border=0 cellspacing=0 cellpadding=0 width='500'>";
    $total = 0;
    foreach($_SESSION['cart'] as $id => $x){
        $result = mysql_query("SELECT * from onlineshop WHERE id=$id",$db);
        $myrow = mysql_fetch_array($result);     
        $name = $myrow['name'];
        $name = substr($name,0,40);
        $price = $myrow['price'];
        $line_cost = $price *  $x;
        $total = $total + $line_cost;

        echo "<tr>";
        echo "<td allign='left'> $name </td>";
        echo "<td align = 'right'>X $x <a href='cart.php?id=".$id."&action=remove'> reduce </a></td>";
        echo "<td align = 'right'>= $line_cost £";
        echo "</tr>";
    }
    echo "<tr>";
    echo "<td align ='right'><br>Total=</td>";
    echo "<td align ='right'><b><br> $total £</b></td>";
    echo "</tr>";
    echo "</table>";
}else
    echo "Cart is empty";

score 0 · Answer 2 · answered Apr 21 '14 at 18:11

0

You should use {} braces instead of () for if's or loop's content block.

if (isset($_SESSION['cart'])) {
//....
}

instead of

if (isset($_SESSION['cart'])) (
//....
)

And the same to foreach loop.

answered Apr 21 '14 at 18:11

Jakub Matczak

15,341
5
46
64

1

dont forget the `foreach` – Logan Murphy Apr 21 '14 at 18:12
You used curly brackets in each example – MrHunter Apr 21 '14 at 18:12
after that I get an error on line -- $result = mysql_query("SELECT * from onlineshop WHERE id=$id",$db); -- error msg *syntax error, unexpected ';' * – cmario Apr 21 '14 at 18:12
*"You should use"* --- Which should be rephrased to "you MUST..." ;-) – Funk Forty Niner Apr 21 '14 at 18:13
Thanks Logan, you're right of course. @cmario - as Logan said, the same for `foreach`. – Jakub Matczak Apr 21 '14 at 18:13
@cmario did you forget about the foreach? :P – Logan Murphy Apr 21 '14 at 18:16

syntax error on php file add to cart

2 Answers2