Java request.getParameter() value in if statement

Question

I am experiencing some strange issues with request.getParameter("param") in Java. I am trying to test the returned value to set a boolean, nothing fancy. :)

String param = String.valueOf(request.getParameter("param"));
boolean paramIsAll = false;
if (param == "all"){paramIsAll = true;}

System.out.println("-"+ param +"-"+ String.valueOf(paramIsAll));

My output is: -all-false

???

See this answer: http://stackoverflow.com/questions/513832/how-do-i-compare-strings-in-java — stridecolossus, Apr 24 '14 at 15:41
Also, an `if` statement that then performs a single line of code that returns or sets a boolean generally indicates poor coding. You can do that in a single line: `boolean paramIsAll = "all".equals(request.getParameter("param"));`. The `getParameter` method also already returns a string, there's no need for the `String.valueOf` call. — Anthony Grist, Apr 24 '14 at 15:44
Thank you for the feedback! I "simplified" the code before posting and have since removed the single line if statement and "String.valueOf" call. — Kermit, Apr 26 '14 at 07:48

score 2 · Accepted Answer · answered Apr 24 '14 at 15:41

2

try with if (param.equals("all")){paramIsAll = true;}

while comparing 2 strings use String#equals()

answered Apr 24 '14 at 15:41

SpringLearner

13,738
20
78
116

Thank you! I discovered my novice error 5 minutes after posting. :) – Kermit Apr 26 '14 at 07:50

FCoelho · Answer 2 · 2014-04-24T16:12:54.517

1

Try: If(param.equalsIgnoreCase("all")){paramIsAll = true;}

edited Apr 24 '14 at 16:12

answered Apr 24 '14 at 16:03

FCoelho

165
1
4
11

Thank you! That seems like a good practice. – Kermit Apr 26 '14 at 07:51

Java request.getParameter() value in if statement

2 Answers2