Objects inside functions not working. Banging my head against this one

Question

I'm using the logging function inside a module. It works fine on the outside of the function "set" but inside it says that logger is not defined. Help?

from peewee import *
import datetime
import logging
import json

#...

# Start up logging
logger = logging.getLogger(__name__)
logger.info("State library started...")

# ...

def set(module, device, state, attributes=None):
    """ Set the state of the specified device"""
    try:
        acquire_lock(device)
    except:
        #state object doesn't exist yet
        pass
    try:
        state_object = StateTable.select().where(StateTable.device == device).get()
    except:
        state_object = StateTable()

    state_object.device = device
    state_object.state = state
    state_object.attributes = attributes
    state_object.lastChange = datetime.datetime.now()
    state_object.save()
    logger.debug("Setting state for", device, "with state", state, "and attributes", attributes)
    release_lock(device)
    logger.debug("SETTING MQTT STATE")
    attributes_mqtt = {"device" : device, "module" : module, "state" : state, "attributes" : json.loads(attributes)}
    logger.debug("MQTT:", attributes_mqtt)
    mqttc.publish("state", json.dumps(attributes_mqtt))

I've put it on pastie because SO won't let me post the full code.

http://pastie.org/9125006

What python version are you using? Is this the *exact* code that is producing the error. I cannot reproduce.. — msvalkon, Apr 29 '14 at 09:50
you haven't used logger inside the function set...could you show the exact function code that makes the interpreter complain — mattgathu, Apr 29 '14 at 10:06
Where is 'acquire_lock' is coming from, if you are doing some multithreading it simply might not have the reference for the logger — lehins, Apr 29 '14 at 12:03
@misspec I absolutely have used it inside set. 3 times infact. — user3579482, Apr 29 '14 at 19:00

score 0 · Accepted Answer · answered Apr 29 '14 at 19:44

Hi I according to your code on pastie, the logger is defined outside of the function set (think of it as a variable) therefore for you to use it within a function you have to pass it to the function i.e. the function your definition should be like this

def set(module, device, state, logger, attributes=None):
    """ Set the state of the specified device"""
    try:
            acquire_lock(device)
    except:
            #state object doesn't exist yet
            pass
    try:
            state_object = StateTable.select().where(StateTable.device == device).get()
    except:
            state_object = StateTable()

    state_object.device = device
    state_object.state = state
    state_object.attributes = attributes
    state_object.lastChange = datetime.datetime.now()
    state_object.save()
    logger.debug("Setting state for", device, "with state", state, "and attributes", attributes)
    release_lock(device)
    logger.debug("SETTING MQTT STATE")
    attributes_mqtt = {"device" : device, "module" : module, "state" : state, "attributes" : json.loads(attributes)}
    logger.debug("MQTT:", attributes_mqtt)
    mqttc.publish("state", json.dumps(attributes_mqtt))

then when you call the set function pass the logger as a parameter.

so I have the pass the logger to every function in the code? — user3579482, Apr 29 '14 at 22:00
yes, but you can also access the logger using the global keyword within your function...check this out http://stackoverflow.com/questions/10588317/python-function-global-variables — mattgathu, Apr 30 '14 at 06:29

Objects inside functions not working. Banging my head against this one

1 Answers1