If and elseif's not working

Question

Sorry for the messy code but basically this code will only ever make $booktype = "ICT" and if I remove the "else" from elseif, it makes it equal ENGLISH.

Whats going wrong?

I've echoed POST_ Book room and that comes out fine.

if ($_POST['bookroom'] == "142" || "040" || "139"|| "104") {
    $booktype = "ICT";
} elseif ($_POST['bookroom'] == "015" || "016" || "017" || "018" || "027" || "028") {
    $booktype = "MATHS";
} elseif ($_POST['bookroom'] == "E03") {
    $booktype = "MUSIC";
} elseif ($_POST['bookroom'] == "202" || "204" || "205" || "206" || "207") {
    $booktype = "ENGLISH";
}

Chris Forrence · Accepted Answer · 2014-05-05T12:14:43.840

5

At the end of the day, you're not using 'or' correctly. To shorten your code, you can do your if-statement like this:

if(in_array($_POST['bookroom'], array("142","040","139","104"))) {

To properly use an "or" or "and" clause, you'd need to make the statement self-contained. That is,

if(this option is true || this option is true || this option is true)
if($a == 4 || $a == 5 || $a == 6)

edited May 05 '14 at 12:14

answered May 04 '14 at 22:09

Chris Forrence

10,042
11
48
64

Although I am receiving syntax errors with your answer :\ – user3586863 May 04 '14 at 22:41
@user3586863 There is a closing bracket missing in first `if` statement. – Linek May 04 '14 at 22:47
@Linek I added that but its still giving me an error. Like it doesn't want the if statement to end. – user3586863 May 04 '14 at 23:24
@user3586863 - I just updated my answer to include the missing closing parenthesis. Check to make sure you've got the other closing parenthesis in the correct spot – Chris Forrence May 05 '14 at 12:16

score 1 · Answer 2 · answered May 04 '14 at 22:08

1

You can't chain conditions like this. Change it to

$_POST['bookroom'] == "142" || $_POST['bookroom'] == "040" || [...]

Also, using a switch case with fall-throughs would be more readable here.

answered May 04 '14 at 22:08

mrks

8,033
1
33
62

1

`in_array($_POST['bookroom'], array('my', 'values'))` would make much more sense. – Wesley Murch May 04 '14 at 22:14
Do NOT use switch. It is an overkill and bad solution in general. Use `in_array` instead as one of the answers states. – Linek May 04 '14 at 22:14

score 1 · Answer 3 · answered May 04 '14 at 22:10

1

You can also change it to use in_array function:

From:

if ($_POST['bookroom'] == "142" || "040" || "139"|| "104"){

to

if (in_array($_POST['bookroom'], array("142","040","139","104"))){

answered May 04 '14 at 22:10

Marcin Nabiałek

109,655
42
258
291

Brotheryura · Answer 4 · 2014-05-04T22:17:35.350

0

You can use switch !

switch($_POST['bookroom']){

case "142":
...
break;

case "040":
...
break;

}

edited May 04 '14 at 22:17

answered May 04 '14 at 22:10

Brotheryura

1,158
13
21

Don't use switch! It is messy, hard to read, a bad solution in general. Especially in this particular very simple problem that is solvable with `in_array` function. – Linek May 04 '14 at 22:13
@Linek Why switch is bad solution О_о?! – Brotheryura May 04 '14 at 22:19
Generally, switch is not bad as a concept but it is bad to use in this particular example. Try go Google "Why is switch bad" and you will find links like this: http://stackoverflow.com/questions/4417070/switch-statements-are-bad Should answer a couple of questions. – Linek May 04 '14 at 22:21

If and elseif's not working

4 Answers4