Valgrind complains "definitely lost of memory" when "new" & "delete" not in the same function

Asked May 08 '14 at 10:23

Active May 08 '14 at 10:31

Viewed 54 times

I am getting this error in valgrind report.

==31766== 8 bytes in 1 blocks are definitely lost in loss record 3 of 825

My code looks like:

struct FooList {
  FooList() {}
  FooList(const vector<Foo*>& fooList_): fooList(fooList_) {}
  ~FooList() {
      BOOST_FOREACH(Foo* fooPtr, fooList) {
        delete fooPtr;
      }
  }  
  vector<Foo*> fooList;
}

Foo* createFoo(bool flag)
{
  if(flag) return new FooDerivedA();
  else     return new FooDerivedB();
}

void main() 
{
  FooList fl;

  Foo* fooA = createFoo(true);
  // some manipulation on fooA, if an exception happens at this point, the memory leaks.
  fl.fooList.push_back(fooA);

  Foo* fooB = createFoo(false);
  // some manipulation on fooB, if an exception happens at this point, the memory leaks.
  fl.fooList.push_back(fooB);

  // fl's desctructor will release memory for all elements.
}

I am not sure if it's because the new and delete statement are not in the same function which causes the definitely lost. How can I fix this?

edited May 08 '14 at 10:31

asked May 08 '14 at 10:23

Stan

37,207
50
124
185

4

Does `Foo` have a virtual destructor? – juanchopanza May 08 '14 at 10:24
It's: ~Foo() {}. How should I fix it? – Stan May 08 '14 at 10:28
1

there should be compile error, `FooList ` does not have default constructor. – Rakib May 08 '14 at 10:29
You need `virtual ~Foo() {}`. – juanchopanza May 08 '14 at 10:31
"which causes the definitely lost" - don't make wild assumptions. – Karoly Horvath May 08 '14 at 10:33
1

@KarolyHorvath: "I'm not sure if it's [...] which causes the definitely lost" - there's no assumption there, just an expression of doubt. – Mike Seymour May 08 '14 at 10:49
@MikeSeymour: let's clean this up. – Karoly Horvath May 08 '14 at 22:16

Valgrind complains "definitely lost of memory" when "new" & "delete" not in the same function

0 Answers0