My IF Functions aren't working

Question

So,

I run a Minecraft server and have a website on separately hosted server. I use a bukkit plugin which sends a value to the database when the player joins. This stored as [BLOB - 1 B] (image below), which is a binary value, so I conevert it into hexadecimal then check its value. As its boolean it can either be 00 - false or 01 - true. But when using my if statements to check what the value is, if the value is 00 it still says online...

My database

But when I use this code on my webserver:

<form action="skript2.php" method="get">  
<input type="text" name="user" />
<input type="submit" name="submit" value="Username" />
</form>
<?php
$uname = $_GET['user'];
$con=mysqli_connect("#####","#####","#####","#####");
// Check connection
if (mysqli_connect_errno()) {
  echo "Failed to connect to MySQL: " . mysqli_connect_error();
}

$result = mysqli_query($con,"SELECT * FROM `variables21` WHERE name='db_sdb.$uname.onlinemode'");
if($row = mysqli_fetch_array($result)) {
  $val = $row['value'];
  $str = bin2hex("$val");
  echo "$str";
  if ($str = 01) {
    echo "<body bgcolor=\"green\">";
    echo "<font color=\"white\"><img src=\"https://minotar.net/helm/$uname/32\"> -- $uname is online!</font>";
  }
  if ($str = 00) {
    echo "<body bgcolor=\"red\">";
    echo "<font color=\"white\"><img src=\"https://minotar.net/helm/$uname/32\"> -- $uname is offline!</font>";
  }
}

mysqli_close($con);
?>

Details where they're ##### is private, such as passwords etc.

The connection works just fine, other wise it return an error saying can't connect.

So why aren't my IF functions working?

Thanks! :)

Because, you're assigning instead of comparing in many of your conditionals. — Funk Forty Niner, May 12 '14 at 15:57
Thanks for the help guys :)! Got it sorted. @NiettheDarkAbsol it was a general mistake on my part, got used to other programming languages... — BaeFell, May 12 '14 at 15:59
You are vulnerable to [SQL injection attacks](http://bobby-tables.com) — Marc B, May 12 '14 at 16:07
This is just a testing page, I have an automatic system in place where the user can't enter anything — BaeFell, May 12 '14 at 16:15

score 2 · Accepted Answer · answered May 12 '14 at 15:57

2

you need == operator

 if ($str == 1) {

}

in Your view

if ($str == 1) {
    echo "<body bgcolor=\"green\">";
    echo "<font color=\"white\"><img src=\"https://minotar.net/helm/$uname/32\"> -- $uname is online!</font>";
  }

For ZERO you can use === operator

if ($str === 0) {
    echo "<body bgcolor=\"red\">";
    echo "<font color=\"white\"><img src=\"https://minotar.net/helm/$uname/32\"> -- $uname is offline!</font>";
  }

answered May 12 '14 at 15:57

underscore

6,495
6
39
78

I'm an idiot! Thank you so much! Got use to VB.NET and just using = :) Thanks! – BaeFell May 12 '14 at 15:58
@nfell2009, Dont feel so bad :) Happy coding. – Shankar Narayana Damodaran May 12 '14 at 15:59
Another reason why VB.NET shouldn't exist anymore. – SQLMason May 12 '14 at 15:59
@DanAndrews :P It's not that bad of a language, I'm only 16. And learnt it for my school GCSE. – BaeFell May 12 '14 at 16:16

score 1 · Answer 2 · answered May 12 '14 at 16:01

1

A single = is binding a value to a variable -

if ($str = 01) {

}

A double == is a comparison operator, think of it as an 'is equal to'.

if ($str == 01) {

}

answered May 12 '14 at 16:01

Danieloplata

222
2
9

For those that habitually get these backwards, express them in the inverse: `01 = $str`. That will automatically fail since you can't make that kind of assignment. – tadman May 12 '14 at 16:09
Thanks! I'm so stupid sometimes xD – BaeFell May 12 '14 at 16:14

My IF Functions aren't working

2 Answers2