Notice message about $_SERVER['HTTP_X_FORWARDED_FOR']

Question

I have self written CMS which does not return correct user's IP address with the following:

define("USER_IP", $_SERVER['HTTP_X_FORWARDED_FOR']);

It gives me the following notice:

Notice: Undefined index: HTTP_X_FORWARDED_FOR in /var/www/p00000/data/www/domain.ru/core/maincore.php on line 30

and line 20 = to the line define("USER_IP"...

A few question:

What should I do to get rid of this notice message?
How can I properly get user's IP address?

Thank you for your help!

HTTP_X_FORWARDED_FOR are usually just set by proxies. So if the user is not using a proxy HTTP_X_FORWARDED_FOR will not be set. And that error you get is that it isn't set — WizKid, May 21 '14 at 16:52

score 0 · Accepted Answer · edited Dec 26 '16 at 17:53

0

if (isset($_SERVER['HTTP_X_FORWARDED_FOR'])){
   define("USER_IP", $_SERVER['HTTP_X_FORWARDED_FOR']); 
} else {
  define("USER_IP", $_SERVER['REMOTE_ADDR']); 
 ...

edited Dec 26 '16 at 17:53

Lal

14,726
4
45
70

answered May 21 '14 at 16:53

cs45977

400
3
11

I already tried it, but the interesting part is: what would you put on else statement? That I am not going to define it? then If I don't define it, variable USER_IP is not going to work on some functions included into CMS. – Alexander Teshabaev May 21 '14 at 17:14
Ok , your original question isn't very clear. you could use $_SERVER['REMOTE_ADDR) (edit made to my answer) – cs45977 May 21 '14 at 17:17
Parse error: syntax error, unexpected '{' in /var/www/p00000/data/www/domain.ru/core/maincore.php on line 30 – Alexander Teshabaev May 21 '14 at 17:21
My code is missing a quote, Are you just copy and pasting without understanding what you are doing? – cs45977 May 21 '14 at 17:22
no, I know that there is a missing quote, but I still receive this error. – Alexander Teshabaev May 21 '14 at 17:23
I think you should have enough to go on .. hope it works out. – cs45977 May 21 '14 at 17:24
Here is the right code: There are a few mistakes you mistakes you did: if (isset($_SERVER['HTTP_X_FORWARDED_FOR'])) { define("USER_IP", $_SERVER['HTTP_X_FORWARDED_FOR']); } else { – Alexander Teshabaev May 21 '14 at 17:25

Notice message about $_SERVER['HTTP_X_FORWARDED_FOR']

1 Answers1