Xcode error: Comparison between pointer and integer?

Question

I am getting this error on my if statement.

CODE:

-(IBAction)login:(id)sender
{

    NSString *correctUser = @"money";
    NSString *correctPassword = @"ilovemoney";

    if ((usernameTextField.text == correctUser)==YES && (passwordTextField.text = correctPassword)==YES) //error is on the beginning of this if statement.
    {
        [self performSegueWithIdentifier:@"oneTransition" sender:sender];
    }

}

What are the types of `usernameTextField.text` and `YES`? – Samuel Edwin Ward May 24 '14 at 16:58 — Samuel Edwin Ward, May 24 '14 at 16:58

score 4 · Answer 1 · answered May 24 '14 at 16:35

4

There are a bunch of problems here.

You're using = instead of == in your second test, which is assignment, not comparison; this is why you're getting the warning.
Comparing strings with == doesn't do what you want. You should use [usernameTextField.text isEqual:correctUser], for example.
You should never compare something to YES as in == YES. So, instead of if (something == YES) just say if (something).

answered May 24 '14 at 16:35

Jesse Rusak

56,530
12
101
102

3

On that third point, you should always use `if( ((((a == b) == YES) == YES) == YES) == YES )`. It's the only way to be sure. – Dave May 24 '14 at 16:37
1

Yes, thanks, @Dave, I had forgotten to mention that. – Jesse Rusak May 24 '14 at 16:39
Thanks. that worked, I used the isEqual. – benr783 May 24 '14 at 16:51

Xcode error: Comparison between pointer and integer?

1 Answers1