Cannot 'insert into' with variables in php

Question

Great, now I can 'insert' into the database, but in phpmyadmin the fields are white, without content... This is the php code:

$name = $_POST["name"];
$institution = $_POST["institution"];
$email = $_POST["email"];
$country = $_POST["country"];
$hcp = $_POST["hcp"];
$texto = $_POST["texto"];
$state = $_POST["state"];
$license = $_POST["license"];

$consulta = ("INSERT INTO `1264`(`name`,`institution`,`email`,`country`,`hcp`,`texto`,`state`,`license`) VALUES ('$name','$institution','$email','$country','$hcp','$texto','$state','$license');");

mysql_query($consulta,$connection) or die("You cannot register. Try it later, please.");

Does anybody know why?

When this will work, it sill be a huge security gap. You should read about prepared statements at least, and sanitize user input as much as possible if not already done. — Laurent S., May 27 '14 at 09:03
add `echo $consulta`; between the two lines and please show us the output of that line - that will show the text that gets sent to the db server. — fvu, May 27 '14 at 09:08
What happened to the extra commas in the question? That was the problem, now the answers make no sense. — Barmar, May 27 '14 at 09:18
This was the old code: $consulta = ("INSERT INTO `1264`(`name`,`institution`,`email`,`country`,`hcp`,`texto`,`state`,`license`,) VALUES ('$name','$institution','$email','$country','$hcp','$texto','$state','$license',);"); — user3665872, May 27 '14 at 09:21
Please be aware that the mysql extension (supplying the `mysql_` functions) has been deprecated since 2012, in favor of the mysqli and PDO extensions. It's use is highly discouraged. See http://stackoverflow.com/questions/12859942/why-shouldnt-i-use-mysql-functions-in-php — Oldskool, May 27 '14 at 13:05

Rahul Tripathi · Answer 1 · 2014-05-27T09:10:08.320

1

Try this:

$consulta = ("INSERT INTO `1264`(`id`,`name`,`institution`,`email`,`country`,`hcp`,`texto`,`state`,`license`) VALUES (NULL, '$institution','$email','$country','$hcp','$texto','$state','$license');");

ie, remove the extra comma at the last

edited May 27 '14 at 09:10

answered May 27 '14 at 09:03

Rahul Tripathi

168,305
31
280
331

1

You still have the extra comma after `license`. – Barmar May 27 '14 at 09:09

fortune · Accepted Answer · 2014-05-27T09:09:11.277

Please change your query

you have extra ',' both after 'license' and '$license'

 $consulta = ("INSERT INTO `1264`(`id`,`name`,`institution`,`email`,`country`,`hcp`,`texto`,`state`,`license`) VALUES (NULL, '$name','$institution','$email','$country','$hcp','$texto','$state','$license');");

 mysql_query($consulta,$connection) or die("You cannot register. Try it later, please.");

Also try using mysqli_* functions. mysql_* functions going to deprecated.

score 0 · Answer 3 · answered May 27 '14 at 09:08

Dont make the query so clumpsy. Here is a simple edit,

$consulta = "INSERT INTO `1264` SET 
    `name` = '$name',
    `institution` = '$institution',
    `email` = '$email',
    `country` = '$country',
    `hcp` = '$hcp',
    `texto` = '$texto',
    `state` = '$state',
    `license` = '$license'";

You don't have to write the id and leave its value field null, it will be auto generated by default.

score 0 · Answer 4 · answered May 27 '14 at 09:13

if id is an primary key then it should not be null and if it is an auto increment field have no need to put it on field list and value
$consulta = ("INSERT INTO 1264(name,institution,email,country,hcp,texto,state,license,) VALUES ( '$name','$institution','$email','$country','$hcp','$texto','$state','$license',);");

do echo $consulta ;

to check if the query is coming properly or try put the variables out of cote check the name one

VALUES ( '".$name."','$institution','$email','$country','$hcp','$texto','$state','$license',)

Thanos Markou · Answer 5 · 2014-05-27T09:21:22.187

-1

Removed the last comma and Id -> NULL so try this:

`$consulta = ("INSERT INTO` `1264`(`name`,`institution`,`email`,`country`,`hcp`,`texto`,`state`,`license`) VALUES `('$name','$institution','$email','$country','$hcp','$texto','$state','$license');");

edited May 27 '14 at 09:21

answered May 27 '14 at 09:03

Thanos Markou

2,587
3
25
32

Although your answer is quite probably correct, please add a short description about what you changed to make it work, for posteriority. – fvu May 27 '14 at 09:06
You haven't fixed the extra comma after `license`. – Barmar May 27 '14 at 09:10

score -1 · Answer 6 · answered May 27 '14 at 09:07

-1

This should work - enter each variable between quotes, especially when its a string

$consulta = ("INSERT INTO `1264`(`id`,`name`,`institution`,`email`,`country`,`hcp`,`texto`,`state`,`license`) VALUES (NULL, "'. $name ."','".$institution."','".$email."','".$country."','".$hcp.'","'.$texto.'","'.$state.'",'".$license."');");

answered May 27 '14 at 09:07

ratmalwer

700
5
14

You still have the extra comma. Why do you think changing from string substitution to concatenation will fix it? – Barmar May 27 '14 at 09:08
You still haven't explained why you think it's necessary to use concatenation instead of interpolation. That's a personal style choice, it doesn't affect the validity of the code. – Barmar May 27 '14 at 09:17

Cannot 'insert into' with variables in php

6 Answers6