My Android Application to show text on Click Stop Working

Question

I have a very very simple project in which what I am trying to achieve is to that when a user click on the button it display the text. But in the ADB it says unfortunately showtext stop working. What is the reason behind this?

I had tried but not got any result. My code is fine but not working. Below is java code for it. I omitted xml code as it contain only the button and a text view not so complex.

public class MainActivity extends Activity {

    Button  ShowText; 
    TextView DisplayText;

        @Override
        protected void onCreate(Bundle savedInstanceState) {
            super.onCreate(savedInstanceState);
            setContentView(R.layout.activity_main);
            ShowText=(Button)findViewById(R.id.bShowText);

        }
        void ShowMeText(View view){
            DisplayText=(TextView)findViewById(R.id.tvShowText);
            DisplayText.setVisibility(View.VISIBLE);

        }
    }

Try solve my this little issue. Thanks in Advance.

As someone asked for logcat error here is it -

06-11 06:51:32.376: E/AndroidRuntime(1223): FATAL EXCEPTION: main
06-11 06:51:32.376: E/AndroidRuntime(1223): java.lang.IllegalStateException: Could not find a method ShowMeText(View) in the activity class com.mylearning.showtext.MainActivity for onClick handler on view class android.widget.Button with id 'bShowText'
06-11 06:51:32.376: E/AndroidRuntime(1223):     at android.view.View$1.onClick(View.java:3620)
06-11 06:51:32.376: E/AndroidRuntime(1223):     at android.view.View.performClick(View.java:4240)
06-11 06:51:32.376: E/AndroidRuntime(1223):     at android.view.View$PerformClick.run(View.java:17721)
06-11 06:51:32.376: E/AndroidRuntime(1223):     at android.os.Handler.handleCallback(Handler.java:730)
06-11 06:51:32.376: E/AndroidRuntime(1223):     at android.os.Handler.dispatchMessage(Handler.java:92)
06-11 06:51:32.376: E/AndroidRuntime(1223):     at android.os.Looper.loop(Looper.java:137)
06-11 06:51:32.376: E/AndroidRuntime(1223):     at android.app.ActivityThread.main(ActivityThread.java:5103)
06-11 06:51:32.376: E/AndroidRuntime(1223):     at java.lang.reflect.Method.invokeNative(Native Method)
06-11 06:51:32.376: E/AndroidRuntime(1223):     at java.lang.reflect.Method.invoke(Method.java:525)
06-11 06:51:32.376: E/AndroidRuntime(1223):     at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:737)
06-11 06:51:32.376: E/AndroidRuntime(1223):     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:553)
06-11 06:51:32.376: E/AndroidRuntime(1223):     at dalvik.system.NativeStart.main(Native Method)
06-11 06:51:32.376: E/AndroidRuntime(1223): Caused by: java.lang.NoSuchMethodException: ShowMeText [class android.view.View]
06-11 06:51:32.376: E/AndroidRuntime(1223):     at java.lang.Class.getConstructorOrMethod(Class.java:423)
06-11 06:51:32.376: E/AndroidRuntime(1223):     at java.lang.Class.getMethod(Class.java:787)
06-11 06:51:32.376: E/AndroidRuntime(1223):     at android.view.View$1.onClick(View.java:3613)
06-11 06:51:32.376: E/AndroidRuntime(1223):     ... 11 more

what is the purpose of the "view" in this function's argument -> void ShowMeText(View view){ ..? — Pararth, Jun 11 '14 at 11:04
@user2450263 it is function that is called when user clicks on button and by default it contains View as parameter: http://stackoverflow.com/questions/4153517/how-exactly-does-the-androidonclick-xml-attribute-differ-from-setonclicklistene — Zoran, Jun 11 '14 at 11:06
@user2450263 view is for the visbility property of the textview — Rajeev Kumar, Jun 11 '14 at 11:07
user3273107 gave correct answer. put public in front of ShowMeText — Zoran, Jun 11 '14 at 11:08
@RajeevKumar but you aren't using the variable "view" at all — Pararth, Jun 11 '14 at 11:20
@user2450263 Read my comment and link i gave you. view MUST be used! — Zoran, Jun 11 '14 at 11:23

score 3 · Answer 1 · answered Jun 11 '14 at 11:06

3

You need to add android:onClick="ShowMeText" in your Button in your Layout. like so

           <Button .............
            android:onClick="ShowMeText"
            ......... />

and used lower case for method creation as Java naming Convention . like so showmetext

and also defined your ShowMeText(...) method as Public

answered Jun 11 '14 at 11:06

M D

47,665
9
93
114

Hey this my xml code what you said i have done already – Rajeev Kumar Jun 11 '14 at 11:10
@RajeevKumar defined your `ShowMeText(...)` method as `Public` – M D Jun 11 '14 at 11:11

score 2 · Accepted Answer · answered Jun 11 '14 at 11:04

2

ShowMeText(View v) has to be public.

Btw. start function names with lower case characters as specified by Java code style.

answered Jun 11 '14 at 11:04

brummfondel

1,202
1
8
11

i renamed the function to "showmetext" but still no sucess – Rajeev Kumar Jun 11 '14 at 11:12
did you put it to be public? and name of function has to be the same in xml and activity – Zoran Jun 11 '14 at 11:13
Did you make it public and also changed the name in android:onClick attribute in the XML? – brummfondel Jun 11 '14 at 11:13
@user3273107 thanks i used the public access specifier and it worked thanks for you help – Rajeev Kumar Jun 11 '14 at 11:15

score 1 · Answer 3 · edited Jun 11 '14 at 11:14

1

 <Button
     android:id="@+id/tvShowText"
     android:layout_width="wrap_content"
     android:layout_height="wrap_content"
     android:onClick="ShowMeText" />

in java code

 public void ShowMeText(View v){
   DisplayText=(TextView)findViewById(R.id.tvShowText);
   DisplayText.setVisibility(View.VISIBLE);
 }

edited Jun 11 '14 at 11:14

MilapTank

9,988
7
38
53

answered Jun 11 '14 at 11:10

Abin

540
4
15

Thanks for the helping was omitting public – Rajeev Kumar Jun 11 '14 at 11:16

MilapTank · Answer 4 · 2014-06-11T11:24:26.980

1

public class MainActivity extends Activity implements OnClickListener {

Button ShowText;
TextView DisplayText;

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);
    ShowText = (Button) findViewById(R.id.bShowText);
    DisplayText = (TextView) findViewById(R.id.tvShowText);
    ShowText.setOnClickListener(this);

}


@Override
public void onClick(View v) {

    if (v.getId() == ShowText.getId())
        // need to check ID because from which view has fire event soo we can handle appropriate 
      DisplayText.setVisibility(View.VISIBLE);
  }
}

edited Jun 11 '14 at 11:24

answered Jun 11 '14 at 11:10

MilapTank

9,988
7
38
53

Thanks for the help as i was omitting public in function – Rajeev Kumar Jun 11 '14 at 11:17
Also as you suggested why we need to check the id? and i am using visibility property and not setting the text. – Rajeev Kumar Jun 11 '14 at 11:18

score 0 · Answer 5 · answered Jun 11 '14 at 11:21

// Try this way,hope this will help you to solve your problem.

activity_main.xml

<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:orientation="vertical"
    android:gravity="center">

    <Button
        android:id="@+id/bShowText"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:text="ShowText"
        android:onClick="ShowMeText"/>
    <TextView
        android:id="@+id/tvShowText"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_marginTop="10dp"
        android:visibility="gone"
        android:text="TextView With Some Text"/>


</LinearLayout>

MainActivity.java

public class MainActivity extends Activity {

    private TextView tvShowText;
    private Button bShowText;
    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);
        tvShowText = (TextView)findViewById(R.id.tvShowText);
        bShowText = (Button)findViewById(R.id.bShowText);

    }

    public void ShowMeText(View v){
        if(v.getId() == bShowText.getId()) {
            if(tvShowText.getVisibility() == View.VISIBLE){
                tvShowText.setVisibility(View.GONE);
            }else{
                tvShowText.setVisibility(View.VISIBLE);
            }


        }
    }

}

score 0 · Answer 6 · answered Jun 11 '14 at 11:22

Try this:

public class MainActivity extends Activity {
        Button  ShowText; 
        TextView DisplayText;

            @Override
            protected void onCreate(Bundle savedInstanceState) {
                super.onCreate(savedInstanceState);
                setContentView(R.layout.activity_main);
                ShowText=(Button)findViewById(R.id.bShowText);
                DisplayText=(TextView)findViewById(R.id.tvShowText);
                DisplayText.setVisibility(View.Gone);
                ShowText.setonClickListener(this);


            }
            public void ShowMeText(View view){

                DisplayText.setVisibility(View.VISIBLE);
                DisplayText.setText("Show your Text");

            }
        }

My Android Application to show text on Click Stop Working

6 Answers6