Activity's onCreate not called on config change if actionbar with custom view is used

Question

I added a customview to the actionbar I am using. Everything works great until the device is rotated. The activity's onCreate is not called and subsequently there are NPE in the fragments where the actionbar's customview is needed.

OTOH, if I comment out all the actionbar related code in the activity. Everything works perfectly fine but without the custom actionbar. The activity's onCreate is:

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);  // LINE 51
    Crashlytics.start(this);
    Log.d(TAG, "onCreate");
    setContentView(R.layout.homescreen_activity);

    actionBarCustomView = LayoutInflater.from(this).inflate(R.layout.homescreen_actionbar, null);
    ActionBar.LayoutParams params = new ActionBar.LayoutParams(ActionBar.LayoutParams.MATCH_PARENT,
            ActionBar.LayoutParams.MATCH_PARENT, Gravity.CENTER);

    getSupportActionBar().setDisplayOptions(ActionBar.DISPLAY_SHOW_CUSTOM);
    getSupportActionBar().setCustomView(actionBarCustomView, params);

    Log.d(TAG, "Activity actionbar NULL ? " + (null == getSupportActionBar()));
    Log.d(TAG, "Activity customview NULL ? " + (null == actionBarCustomView));

    settingsFromActionbar = (ImageButton) actionBarCustomView.findViewById(R.id.settingsFromActionBar);
    settingsFromActionbar.setOnClickListener(new OnClickListener() {

        @Override
        public void onClick(View v) {
            Toast.makeText(HomeScreenActivity.this, "Touched Settings", Toast.LENGTH_SHORT).show();
            Intent settingIntent = new Intent(HomeScreenActivity.this, SettingsActivity.class);
            startActivity(settingIntent);

        }
    });

    fm = getSupportFragmentManager();
    homeScreenFragment = fm.findFragmentByTag("homeScreen");

    if (homeScreenFragment == null) {
        homeScreenFragment = new HomeScreenFragment();
        getSupportFragmentManager().beginTransaction()
                .add(R.id.homescreen_container, homeScreenFragment, "homeScreen").commit();
    }
}

}

EDIT: I dont have android:configChanges in my mainfest file -

<!-- HOME SCREEN ACTIVITY -->
    <activity
        android:name="com.example.try_masterdetail.homescreen.HomeScreenActivity"
        android:label="@string/app_name"
        android:theme="@style/TrasnparentActionBarTheme" >
        <intent-filter>
            <action android:name="android.intent.action.MAIN" />

            <category android:name="android.intent.category.LAUNCHER" />
        </intent-filter>
    </activity>

EDIT: LOGCAT -

  FATAL EXCEPTION: main


Process: com.example.try_masterdetail, PID: 5240
  java.lang.RuntimeException: Unable to start activity ComponentInfo{com.example.try_masterdetail/com.example.try_masterdetail.homescreen.HomeScreenActivity}: java.lang.NullPointerException
    at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2195)
    at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2245)
    at android.app.ActivityThread.handleRelaunchActivity(ActivityThread.java:3738)
    at android.app.ActivityThread.access$900(ActivityThread.java:135)
    at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1202)
    at android.os.Handler.dispatchMessage(Handler.java:102)
    at android.os.Looper.loop(Looper.java:136)
    at android.app.ActivityThread.main(ActivityThread.java:5017)
    at java.lang.reflect.Method.invokeNative(Native Method)
    at java.lang.reflect.Method.invoke(Method.java:515)
    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:779)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:595)
    at dalvik.system.NativeStart.main(Native Method)
  Caused by: java.lang.NullPointerException
    at com.example.try_masterdetail.homescreen.HomeScreenFragment.onAttach(HomeScreenFragment.java:94)
    at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:894)
    at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1115)
    at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1097)
    at android.support.v4.app.FragmentManagerImpl.dispatchCreate(FragmentManager.java:1890)
    at android.support.v4.app.FragmentActivity.onCreate(FragmentActivity.java:215)
    at android.support.v7.app.ActionBarActivity.onCreate(ActionBarActivity.java:97)
    at com.example.try_masterdetail.homescreen.HomeScreenActivity.onCreate(HomeScreenActivity.java:51)
    at android.app.Activity.performCreate(Activity.java:5231)
    at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1087)
    at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2159)
    ... 12 more

HomeScreenFragment -

    @Override
public void onAttach(Activity activity) {
    super.onAttach(activity);
    try {
        activityCallback = (Callbacks) activity;
    } catch (ClassCastException e) {
        throw new ClassCastException(activity.toString() + " must implement ToolbarListener");
    }

    Log.d(TAG, "fragment activity NULL ? " + (null == activity));  // This comes as false
    actionBar = ((ActionBarActivity) activity).getSupportActionBar();
    Log.d(TAG, "fragment actionbar NULL ? " + (null == actionBar)); // This comes as true
    actionBarCustomView = actionBar.getCustomView(); //LINE 94

}

Have a look at this: http://stackoverflow.com/questions/6867076/getactionbar-returns-null — SoundsDangerous, Jun 12 '14 at 15:10
@SoundsDangerous Hi, I tried the above. Moved setContentView to after setting the custom view, but it didnt work — Sahil Dave, Jun 12 '14 at 15:32

score 0 · Accepted Answer · answered Jun 12 '14 at 17:12

Apparently Fragment's onAttach() is called before Activity's onCreate() when the device is rotated. So the actionbar was never formed when the program tried to get it in Fragment's onAttach().

More - After the rotate, onCreate() Fragment is called before onCreate() FragmentActivity

Activity's onCreate not called on config change if actionbar with custom view is used

1 Answers1