Invalid URI: The format of the URI could not be determined using file upload to ftp

Question

I have tried this code for uploading files to ftp server but this error comes up.I dont where am I going wrong. I tried various ways changing my ftpurl format but still no luck.

Code:

 private void button1_Click_1(object sender, EventArgs e)
        {
            UploadFileToFTP(sourcefilepath);
        }
        private static void UploadFileToFTP(string source)
        {
            String sourcefilepath = "C:/Users/Desktop/LUVS/*.xml";  
            String ftpurl = "100.100.0.35"; // e.g. fake IDs
            String ftpusername = "ftp"; // e.g. fake username
            String ftppassword = "1now"; // e.g. fake password


            try
            {
                string filename = Path.GetFileName(source);
                string ftpfullpath = ftpurl;
                FtpWebRequest ftp = (FtpWebRequest)FtpWebRequest.Create(ftpfullpath);
                ftp.Credentials = new NetworkCredential(ftpusername, ftppassword);

                ftp.KeepAlive = true;
                ftp.UseBinary = true;
                ftp.Method = WebRequestMethods.Ftp.UploadFile;

                FileStream fs = File.OpenRead(source);
                byte[] buffer = new byte[fs.Length];
                fs.Read(buffer, 0, buffer.Length);
                fs.Close();

                Stream ftpstream = ftp.GetRequestStream();
                ftpstream.Write(buffer, 0, buffer.Length);
                ftpstream.Close();
            }
            catch (Exception ex)
            {
                throw ex;
            }

Which line throws the error and what is the runtime value of the erroneous URI on that line? (Hint: It would be a lot easier to determine such things if you weren't throwing away your stack trace. Your exception handler isn't doing anything, but is throwing away useful information. Just get rid of the exception handler entirely in its current form and let the original exception be thrown.) — David, Jun 13 '14 at 09:51
Hi David, its giving me the error at this line `FtpWebRequest ftp = (FtpWebRequest)FtpWebRequest.Create(ftpfullpath);` — shruthi, Jun 13 '14 at 09:58
The error is pretty clear: "100.100.0.35" is not an URI. You're missing a scheme, in this case `ftp://`. — CodeCaster, Jun 13 '14 at 10:10
I tried this it gives me - Illegal characters in path exception on this line `FileStream fs = File.OpenRead(source);`- — shruthi, Jun 13 '14 at 10:15
One request is for one file. You can't use `*`, you'll have to loop through all files by code. See [Get all files and directories in specific path fast](http://stackoverflow.com/questions/6061957/get-all-files-and-directories-in-specific-path-fast). — CodeCaster, Jun 13 '14 at 10:19

Ricky · Accepted Answer · 2014-06-13T10:37:59.657

3

The error is in ftp url. You have not included the file name. Write it like this:

    private static void UploadFileToFTP(string source)
    {
        String sourcefilepath = "C:\\Users\\Desktop\\LUVS\\a.xml";  
        String ftpurl = "100.100.0.35"; // e.g. fake IDs
        String ftpusername = "ftp"; // e.g. fake username
        String ftppassword = "1now"; // e.g. fake password


        try
        {
            string filename = Path.GetFileName(sourcefilepath);
            string ftpfullpath = "ftp://" + ftpurl + "/" + filename ;
            FtpWebRequest ftp = (FtpWebRequest)FtpWebRequest.Create(ftpfullpath);
            ftp.Credentials = new NetworkCredential(ftpusername, ftppassword);

            ftp.KeepAlive = true;
            ftp.UseBinary = true;
            ftp.Method = WebRequestMethods.Ftp.UploadFile;

            FileStream fs = File.OpenRead(sourcefilepath); // here, use sourcefilepath insted of source.
            byte[] buffer = new byte[fs.Length];
            fs.Read(buffer, 0, buffer.Length);
            fs.Close();

            Stream ftpstream = ftp.GetRequestStream();
            ftpstream.Write(buffer, 0, buffer.Length);
            ftpstream.Close();
        }
        catch (Exception ex)
        {
            throw ex;
        }
    }

edited Jun 13 '14 at 10:37

answered Jun 13 '14 at 09:59

Ricky

2,323
6
22
22

string ftpfullpath = ftpurl + "/" + filename ; i dont understand "/" filename its just the addesss of ftp right where is this filename come from – shruthi Jun 13 '14 at 10:03
but still the same error – shruthi Jun 13 '14 at 10:03
There you go. Check my answer. Now it should work. – Ricky Jun 13 '14 at 10:05
Forgot to add the protocol `ftp` – Ricky Jun 13 '14 at 10:06
hey ricky, Now I get the error here `FileStream fs = File.OpenRead(source);` – shruthi Jun 13 '14 at 10:07
oh sorry - this error- Illegal characters in path. – shruthi Jun 13 '14 at 10:12
have you solved this error? – Ricky Jun 13 '14 at 10:17
What is your source path? – Ricky Jun 13 '14 at 10:18
"C:/Users/IT-Administrator/Desktop/LUVS/*.xml" – shruthi Jun 13 '14 at 10:19
Oh yes. you can't use *.xml. Upload one file at a time. – Ricky Jun 13 '14 at 10:20
i tried with one file still the same error – shruthi Jun 13 '14 at 10:23
use this as a path `C:\\Users\\IT-Administrator\\Desktop\\LUVS\\test.xml` – Ricky Jun 13 '14 at 10:25
still the same rickey – shruthi Jun 13 '14 at 10:32
Made changes in my answer. Check the comments. – Ricky Jun 13 '14 at 10:38
Let us [continue this discussion in chat](http://chat.stackoverflow.com/rooms/55564/discussion-between-ricky-and-shruthi). – Ricky Jun 13 '14 at 10:45

score 2 · Answer 2 · answered Jun 13 '14 at 10:05

2

The Create method appears to be on WebRequest, not on FtpWebRequest. And WebRequest needs to determine from the URI which child object to create (in this case FtpWebRequest) based on the format of the URI. But your URI is just a bare address:

"100.100.0.35"

If you prepend a protocol, it should be able to determine what it needs from the URI:

"ftp://100.100.0.35"

answered Jun 13 '14 at 10:05

David

208,112
36
198
279

Hi David I have tried this but given an error Illegal characters in path exception on this line `FileStream fs = File.OpenRead(source); ` – shruthi Jun 13 '14 at 10:18
@shruthi: And what is the value of `source` when that happens? You need to examine these runtime values and do at least *some* debugging. – David Jun 13 '14 at 10:43

Invalid URI: The format of the URI could not be determined using file upload to ftp

2 Answers2