$filter is not a function AngularJS

Question

app.controller('myController', ['$scope', '$http', '$filter', function($scope, $http, $filter) {

The above is an example of my code where I am trying to use $http.get and also $filter inside my controller.

The only problem is when I use it like so, the console log throws an error that says $filter is not a function.

app.controller('myController', ['$scope', '$http', '$filter', function($scope, $filter, $http) {

When I swap them round it throws an error that $http is undefined

You have to declare `$filter` in the dependency list, i.e. `['$scope', '$http', '$filter', function($scope, $http, $filter) {...` — Nikos Paraskevopoulos, Jun 18 '14 at 11:44
@NikosParaskevopoulos Sorry I forgot to add that into the example, it shows the error with this in the dependency list. — ngplayground, Jun 18 '14 at 11:45
OK; there is something really fishy here. This code *should* work. Can you reproduce the problem in a fiddle/plunk? — Nikos Paraskevopoulos, Jun 18 '14 at 12:02
How did you finally resolve this issue? I'm having the same problem and the answer marked below isn't working. I have the order correctly in place — nikjohn, Jul 08 '15 at 22:52

score 25 · Accepted Answer · answered Jun 18 '14 at 11:56

When you are using

app.controller('myController', ['$scope', '$http', '$filter', function($scope, $filter, $http) {

variable $filter is actually a instance of $http, and $http is instance of $filter. Actually it doesn't matter what is written in function(...) params.

What is important here, is the order of injectibles you are using, for example

app.controller('myController', ['$scope', '$http', '$filter', function(a, b, c) {

will map to instances:

a -> scope
b -> $http
c -> $filter

From angular docs:

Since Angular infers the controller's dependencies from the names of arguments to the controller's constructor function, if you were to minify the JavaScript code for PhoneListCtrl controller, all of its function arguments would be minified as well, and the dependency injector would not be able to identify services correctly.

So by using array notation for yout controller, you are making sure that code will work after code is minified.

while not the exact scenario, conflicting with http, I still found that changing the order fixed my issue — SeanMC, Jun 21 '18 at 14:59

score 2 · Answer 2 · answered Jan 31 '17 at 10:22

add filter after http and angular version also defends how you are going to use filter.

     plateFormController.$inject = ['$scope', '$http',
    '$filter','$timeout', '$q', '$mdSidenav', '$log'];



function plateFormController($scope, $http,$filter, $timeout, $q) {
          jsonByName=$filter('filter')($scope.json, { name: 'a' });
        }

score 0 · Answer 3 · answered Nov 28 '17 at 12:29

0

In my case, expected data List object is null, by ensuring that expected List Object not null. I am able to avoid this error.

answered Nov 28 '17 at 12:29

Ravi

15
7

$filter is not a function AngularJS

3 Answers3