PHP MySQLi Fatal error: Call to a member function fetch_array() on a non-object in

Question

Getting this error and not sure what's going on. New to using mysqli.

$query = 'SELECT name, email FROM US__users WHERE state="' . $state . '" ORDER BY zip ASC LIMIT 5';
$result = $mysqli->query($query);

while ($row = $result->fetch_array()) {
  print ($row['name'] . ' ' . $row['email']);
}

$result->free();

There's currently only one row in MySQL DB. However, when I copy the $query and run it at the mysql command prompt, it queries fine and displays one result.

You should use a prepared statement with placeholders and bind your variable to this placeholder. That would take care of your error and your sql injection vulnerability too. — VMai, Jun 19 '14 at 21:12
The variable comes from another php file and not something that a user can set. Each file has $state = ''; and depending which file they use, populates the $state variable in this query. So I don't believe that would be cause for SQL injection. — user3727412, Jun 19 '14 at 21:18
That's no cause not to use prepared statements. There are other issues too. Where is your error checking? — VMai, Jun 19 '14 at 21:21

Giacomo1968 · Answer 1 · 2014-06-19T21:21:46.287

2

The query string is syntactically incorrect. You have this:

$query = 'SELECT name, email FROM users WHERE state="' $state '" ORDER BY zip ASC LIMIT 5';

Try this instead using double quotes (") which allow for string substitution:

$query = "SELECT name, email FROM users WHERE state='$state' ORDER BY zip ASC LIMIT 5";

Or this if you want concatenation of values in the string for some reason:

$query = "SELECT name, email FROM users WHERE state='" . $state . "' ORDER BY zip ASC LIMIT 5";

Another idea if you still have issues is to use a prepared statement method; you never know if state needs to be filtered or not. So try this.

$query = "SELECT name, email FROM US__users WHERE state=? ORDER BY zip ASC LIMIT 5";

$stmt = $mysqli->prepare($query);

$stmt->bind_param('s', $state);

$result = $stmt->execute();

$stmt->close();

while ($row = $result->fetch_array()) {
  print ($row['name'] . ' ' . $row['email']);
}

$result->free();

edited Jun 19 '14 at 21:21

answered Jun 19 '14 at 21:09

Giacomo1968

25,759
11
71
103

The query isn't syntactically incorrect, but the concatenation which builds the query is. – Winfield Trail Jun 19 '14 at 21:10
1

which makes it syntactically incorrect as a result – vico Jun 19 '14 at 21:11
@sudowned Minor issue in semantics, but I changed it to `The query string is syntactically incorrect.` – Giacomo1968 Jun 19 '14 at 21:12
@JakeGould Call to a member function bind_param() on a non-object in – user3727412 Jun 19 '14 at 21:24
@user3727412 If that is the case do you even have a `mysqli` connection happening? `$mysqli = new mysqli('localhost', 'username', 'password', 'database');`? – Giacomo1968 Jun 19 '14 at 21:27
yes, and if I change the password or some value it'll give me a connection error message. – user3727412 Jun 19 '14 at 21:45
@JakeGould the error is now failing at while ($row = $result->fetch_array()) { – user3727412 Jun 19 '14 at 22:30
@user3727412 I have helped you the best I can. The rest is in your court now. It seems like you have larger issues outside of the code posted since this code should work. Best of luck! – Giacomo1968 Jun 19 '14 at 22:36

score 0 · Answer 2 · edited May 23 '17 at 10:27

0

You are missing concatenation on your query definition:

$query = 'SELECT name, email FROM users WHERE state="' . $state . '" ORDER BY zip ASC LIMIT 5';

Take a look at following link for further info: call to a member function non-object

edited May 23 '17 at 10:27

Community

1
1

answered Jun 19 '14 at 21:10

aaronfc

190
8

It's worth mentioning that PHP shouldn't have got this far - it should terminate at the syntax error where concat operators are omitted. – Winfield Trail Jun 19 '14 at 21:11
I forgot to put the concatenation. I edited my first post. – user3727412 Jun 19 '14 at 21:16
Totally but the author seems to not have this problem. Any idea? – aaronfc Jun 19 '14 at 21:16
@user3727412 if the concatenation is not the problem, then you probably have some kind of error in your SQL query. The main error you are reporting is because the *query* call is not generating what you expect to be. – aaronfc Jun 19 '14 at 21:18
but the query works in mysql and phpmyadmin. So why would it not work here? – user3727412 Jun 19 '14 at 21:19
That's pretty weird ... Are you connecting successfully to your database? Try a simple query like a `describe US__users`. I saw in other comments that you tested the connection is ok. What data type is the state field ? – aaronfc Jun 19 '14 at 21:22
No error doing a describe. – user3727412 Jun 19 '14 at 22:19
Fields are either vchar or int. – user3727412 Jun 19 '14 at 22:20

score -1 · Answer 3 · edited Jun 19 '14 at 21:10

-1

Query is breaking due to

state="' $state '"

Try as

$query = "SELECT name, email FROM 
users WHERE state='$state' ORDER BY zip ASC LIMIT 5";

edited Jun 19 '14 at 21:10

Giacomo1968

25,759
11
71
103

answered Jun 19 '14 at 21:09

Abhik Chakraborty

44,654
6
52
63

Still having error. Is it because the table name has a double underscore? – user3727412 Jun 19 '14 at 21:12
no double underscore should not be an issue. And down voter it would be nice if you leave a reason too. – Abhik Chakraborty Jun 19 '14 at 21:14
ok, then not sure why i'm still getting an error. – user3727412 Jun 19 '14 at 21:17
are you sure you are connected to mysql ? check if its connected to mysql before executing the query. – Abhik Chakraborty Jun 19 '14 at 21:18
It is, I changed $host to $hst and I saw the connection error. – user3727412 Jun 19 '14 at 21:20
if the connection is fine and there is a value for `$state` then it should work, what you get if you do a simple query like `SELECT name, email FROM users order by zip LIMIT 5` ? – Abhik Chakraborty Jun 19 '14 at 21:25
So the initial issue was I renamed the table and the user didn't have permissions. But now I'm getting an error regarding @JakeGould on his while loop. – user3727412 Jun 19 '14 at 22:30

score -1 · Answer 4 · answered Sep 24 '16 at 20:36

It could be a PHP bug? Just faced the same issue. So it doesn't work as you wanted (for future people, who like me will be searching for the answer): while ($row = $result->fetch_array()) {. But for some reason it works like this(looks pretty ugly though)

$query = 'SELECT name, email FROM US__users WHERE state="' . $state . '" ORDER BY zip ASC LIMIT 5';

while ($row = $mysqli->fetch_array($query)) {...

PHP MySQLi Fatal error: Call to a member function fetch_array() on a non-object in

4 Answers4