Closing Connection, PreparedStatement, and ResultSet all in one call

Question

Is there anything wrong in closing my connection resources like this? I seem to still have idle connections in postgres running.

public void doSomething(){
  Connection con = null;
  PreparedStatement ps = null;
  ResultSet rs = null;
  try{
    con = getConnection();
    ps = con.prepareStatement("sql here");
    ....
    rs = ps.executeQuery();
    ...
   } catch(Exceptions stuff){
   } finally {
     closeAll(con,ps,rs);
   }
}
public void closeAll(Connection con, PreparedStatement ps, ResultSet rs){
  try{
        if(rs != null){
            rs.close();
        }
        if(ps != null){
            ps.close();
        }
        if(con != null){
            con.close();
        }
    } catch(SQLException e){
        ....
    }
}

Yes, if closing the first throws an exception the rest won't be closed. Use Java 7 try-with-resources and don't try to invent square wheels. — Boris the Spider, Jun 26 '14 at 21:53
Agreed. Good example of JDBC try-with-resources is [here](http://stackoverflow.com/questions/8066501/how-should-i-use-try-with-resources-with-jdbc). — sparc_spread, Jun 26 '14 at 22:01

score 1 · Accepted Answer · answered Jun 27 '14 at 03:14

Practice the Best Practice

Yes, their is a problem in closing connection the way you have closed.

Suppose, an exception occurred while closing ResultSet object the rest things would not be closed

Second, suppose if everything goes fine, still you are holding other connection (etc) you are not using, it adds to the burden to the JVM, Database, Memory manager etc

It is recommended to use " try(){} with resource " feature available in JAVA 7 or if you are using JAVA 6 close them when it is no longer needed.

Closing Connection, PreparedStatement, and ResultSet all in one call

1 Answers1

Practice the Best Practice