Exit while loop of mouseDown event

Question

I am trying to make my Form, which has no border, moveable with holding the left mousebutton down and exit the while loop, when releasing the mousebutton. But the code I have right now doesn't exit the loop on release.

    private void Form1_MouseDown(object sender, MouseEventArgs e)
    {
        mouseDown = true;

        while (mouseDown)
        {
            mouseX = MousePosition.X;
            mouseY = MousePosition.Y - 30;
            this.SetDesktopLocation(mouseX, mouseY);

            if (e.Button != MouseButtons.Left)
                mouseDown = false;
        }

I also tried to add a mouseUp event but it cant happen as long as mouseDown is active.

    private void Form1_MouseUp(object sender, MouseEventArgs e)
    {
        mouseDown = true;
    }

Possible duplicate, check http://stackoverflow.com/questions/7712309/c-sharp-loop-while-mousedown-button-pressed — Daniel B, Jun 30 '14 at 12:46
The function parameter MouseEventArgs e does not change value during execution — supertopi, Jun 30 '14 at 12:46
I am not a fan of adding mouse listeners via C#. Usually I try to seperate a lot of the FrontEnd from C# — Fallenreaper, Jun 30 '14 at 12:47
@FallenReaper implementing WPF application UI with C# is actually not that bad :) — supertopi, Jun 30 '14 at 12:48

score 4 · Accepted Answer · edited Jun 24 '17 at 16:57

OK, I fixed it for myself.

I just did this:

private void Form1_MouseDown(object sender, MouseEventArgs e)
{
    mouseDown = true;
}

private void Form1_MouseUp(object sender, MouseEventArgs e)
{
    mouseDown = false;
}

private void Form1_MouseMove(object sender, MouseEventArgs e)
{
    if (mouseDown)
    {
        mouseX = MousePosition.X - 20;
        mouseY = MousePosition.Y - 40;
        this.SetDesktopLocation(mouseX, mouseY);
    }
}

score 1 · Answer 2 · answered Jun 30 '14 at 12:51

1

By using a loop in the on mouse up event you are locking the thread. You could use the MouseMove event with a public variable to check if the mouse is down.

answered Jun 30 '14 at 12:51

Valderann

805
12
30

Exit while loop of mouseDown event

2 Answers2