Why do I get "Undefined variable" in my custom PHP function

Question

I work with PHP Simple Dom Parser. Actually, I created a test for each tag I want to test like this:

if(count($html->find('section')) == 0){
echo '<p class="pstatus bg-danger"><span class="glyphicon glyphicon-remove"></span>Aucune balise sémantique section.</p>';
}
elseif(count($html->find('section')) >= 1){
echo '<p>Nombre de balises sémantiques section: <span>' . count($html->find('section')) . '</span></p>';    
}

I try to create a function to rewrite all my code to get less lines. I tried this:

function ftest($balise,$balisetxt){
if(count($html->find('$balise')) == 0){
    echo '<p class="pstatus bg-danger"><span class="glyphicon glyphicon-remove"></span>Aucune $balisetxt.</p>';
}
elseif(count($html->find('$balise')) >= 1){
    echo '<p>Nombre de $balisetxt: <span>' . count($html->find('section')) . '</span></p>'; 
}
}

ftest('section', 'balise sémantique section');

But I got these

Notice: Undefined variable: html in E:\xampp\htdocs\testmobile\index.php on line 69

Fatal error: Call to a member function find() on a non-object in E:\xampp\htdocs\testmobile\index.php on line 69

It's like PHP can't access the $html->find thing from PHP Simple Dom Prser within a function. How should I do?

Does this answer your question? [Reference: What is variable scope, which variables are accessible from where and what are "undefined variable" errors?](https://stackoverflow.com/questions/16959576/reference-what-is-variable-scope-which-variables-are-accessible-from-where-and) — Syscall, Jan 16 '22 at 12:00

Lawrence Cherone · Accepted Answer · 2014-07-01T14:11:55.700

$html wont have scope within the function, either pass it as an argument or use the global keyword to get scope. Also $html->find('$balise') should be $html->find($balise).

<?php 
/**
 * find text, yada..
 * @uses $html
 * @param string $balise
 * @param string $balisetxt
 * @return string
 */
function ftest($balise,$balisetxt)
{
    global $html;

    $return = null;

    if(count($html->find($balise)) == 0)
    {
        $return = '<p class="pstatus bg-danger"><span class="glyphicon glyphicon-remove"></span>Aucune '.htmlentities($balisetxt, ENT_QUOTES, "UTF-8").'.</p>';
    } else 

    if(count($html->find($balise)) >= 1)
    {
        $return = '<p>Nombre de '.htmlentities($balisetxt, ENT_QUOTES, "UTF-8").': <span>' . count($html->find('section')) . '</span></p>';
    }
    return $return;
}

ftest('section', 'balise sémantique section');
?>

Ok I see. I added $html as a parameter and now it works! I will also try with the global $html. — Lucien Dubois, Jul 01 '14 at 14:07

score 0 · Answer 2 · answered Jul 01 '14 at 14:05

0

You should learn more about PHP and its scopes: http://www.php.net/manual/fr/language.variables.scope.php (French content as you look to be french)

In a nutshell, A function can't access a variable not defined in it / not passed via a parameter

answered Jul 01 '14 at 14:05

punkeel

869
8
12

Ok I see. I added $html as a parameter and now it works! – Lucien Dubois Jul 01 '14 at 14:07

Why do I get "Undefined variable" in my custom PHP function

2 Answers2