Destination ViewController not changing after segue

Question

My destination ViewController has a number of labels and images which need to be changed dependent on the specific previous ViewController. I have a segue set up which should change these but for some reason it is not, even though the segue is being called.

My initial ViewController has a button which has a segue passing to the next ViewController with the name "aName". I'm probably missing something simple but I have been following another section of my code which does the exact same thing and works! I have also tested that the segue is successfully being called with a NSLog which returns fine. All the IBOutlets are also assigned correctly.

Initial View Controller.m:

#import "dViewController.h"

-(void) prepareForSegue:(UIStoryboardSegue *)segue sender:(id)sender {
        if ([segue.identifier isEqualToString:@"aName"]) {
            dViewController *dVC = (dViewController *)segue.destinationViewController;
            dVC.TitleLabel.text = @"abc";
            dVC.1Img.image = [UIImage imageNamed:@"somepath.jpg"];
            dVC.2Img.image = [UIImage imageNamed:@"somepath2.jpg"];
            [dVC.1Button setTitle:@"abcd" forState:UIControlStateNormal];
            [dVC.1Button setTitle:@"efgh" forState:UIControlStateNormal];

        }

Destination ViewController:

dViewController.h

    @property (strong, nonatomic) IBOutlet UILabel *TitleLabel;
    @property (strong, nonatomic) IBOutlet UIImageView *1Img;
    @property (strong, nonatomic) IBOutlet UIImageView *2Img;
    @property (strong, nonatomic) IBOutlet UIButton *1Button;
    @property (strong, nonatomic) IBOutlet UIButton *2Button;

Edit: From doing some more looking around I think I should be using a delegate. It seems quite complicated and not really sure where I start. But I'll have a go at looking at what's in this thread: Changing label's text in another view controller

Are your view controllers in navigation controller? Otherwise you wouldn't be able to push to stack. — PiotrDomo, Jul 02 '14 at 18:47
@sumofighter666 So for a segue to work, they need to be navigation controllers? — user3728778, Jul 02 '14 at 19:02
For what you are expecting to achieve yes. Unless you want to display your view as modal view. But this is not what you are asking — PiotrDomo, Jul 02 '14 at 19:06

Klinkert0728 · Accepted Answer · 2014-07-30T19:05:43.137

you have to create a variable for each label you want to change and in viewDidLoad assing the variable to the label.text

for example

 - (void) prepareForSegue:(UIStoryboardSegue *)segue sender:(id)sender {

    if ([segue.identifier isEqualToString:@"aName"]) {
        dViewController *dVC = (dViewController *)segue.destinationViewController;
        dVC.titleString = @"abc";
        dVC.1Image = [UIImage imageNamed:@"somepath.jpg"];
        dVC.2Image = [UIImage imageNamed:@"somepath2.jpg"];
        dVC.1ButtonString=@"ButtonTitle";
        dVC.2ButtonString=@"ButtonTitle2";

    }

in DestinationController

    @property (strong, nonatomic) IBOutlet UILabel *TitleLabel;    
    @property (strong, nonatomic) IBOutlet UIImageView *1Img;      
    @property (strong, nonatomic) IBOutlet UIImageView *2Img;      
    @property (strong, nonatomic) IBOutlet UIButton *1Button;  
    @property (strong, nonatomic) IBOutlet UIButton *2Button;  

    @property(strong,nonatomic)NSString *2ButtonString;  
    @property(strong,nonatomic)UIImage*1Image;  
    @property(strong,nonatomic)UIImage*2Image;  
    @property(strong,nonatomic)NSString* titleString;  
    @property(strong,nonatomic)NSString *1ButtonString;  
    @property(strong,nonatomic)UIImageView *1Img;  
    @property(strong,nonatomic)UIImageView *1Img;  



 - (void)viewDidLoad{

   self.TitleLabel.text = self.titleString;

   self.1Img.image = self.1Image;

   self.2Img.image = self.2Image;

   [self.1Button setTitle:self.1ButtonString];

   [self.2Button setTitle:self.1ButtonString];

}

hope It help you, the problem is that with

 dViewController *dVC = (dViewController *)segue.destinationViewController;

you only bring the controller not the view. and the IBOutlet belongs to the view and the view is not load i hope you understand

That worked, exactly how I wanted. I'm not sure if everyone else understood what I meant. But this explanation makes sense to why it was happening in the first place. — user3728778, Jul 03 '14 at 00:25

JackyJohnson · Answer 2 · 2014-07-02T19:13:00.947

0

Put parentheses around segue.destinationViewController like this:

        dViewController *dVC = (dViewController *)(segue.destinationViewController);

edited Jul 02 '14 at 19:13

answered Jul 02 '14 at 18:41

JackyJohnson

3,106
3
28
35

yes just edited then, was meant to dVC-it's correct in xcode. – user3728778 Jul 02 '14 at 18:44
does it transition to the destination view controller? – JackyJohnson Jul 02 '14 at 18:47
no, @synthesize didn't change it, still not displaying. – user3728778 Jul 02 '14 at 18:52
if it's not transitioning, then no wonder label/image properties aren't being written. I'd check your initial and destination VC's in storyboard and make sure the segue name matches the specified identifier. – JackyJohnson Jul 02 '14 at 18:58
Sorry, meant it is transitioning, just not displaying the changed information. – user3728778 Jul 02 '14 at 19:01
you said that you checked with NSLog inside the if statement it matches identifier aName? – JackyJohnson Jul 02 '14 at 19:12
Yes I checked with the NSLog that it segue identifier is correct. Looking further into it, I think I might need to use a delegate pattern. – user3728778 Jul 02 '14 at 20:52

score 0 · Answer 3 · answered Jul 02 '14 at 18:59

0

Read about app navigation principles. From apple:

https://developer.apple.com/library/ios/documentation/WindowsViews/Conceptual/ViewControllerCatalog/Chapters/NavigationControllers.html

answered Jul 02 '14 at 18:59

PiotrDomo

1,045
10
29

Destination ViewController not changing after segue

3 Answers3