run shell command from java

Question

I am working on an application an have an issue about running shell command from java application. here is the code:

public String execRuntime(String cmd) {

        Process proc = null;
        int inBuffer, errBuffer;
        int result = 0;
        StringBuffer outputReport = new StringBuffer();
        StringBuffer errorBuffer = new StringBuffer();

        try {
            proc = Runtime.getRuntime().exec(cmd);
        } catch (IOException e) {
            return "";
        }
        try {
            response.status = 1;
            result = proc.waitFor();
        } catch (InterruptedException e) {
            return "";
        }
        if (proc != null && null != proc.getInputStream()) {
            InputStream is = proc.getInputStream();
            InputStream es = proc.getErrorStream();
            OutputStream os = proc.getOutputStream();

            try {
                while ((inBuffer = is.read()) != -1) {
                    outputReport.append((char) inBuffer);
                }

                while ((errBuffer = es.read()) != -1) {
                    errorBuffer.append((char) errBuffer);
                }

            } catch (IOException e) {
                return "";
            }
            try {
                is.close();
                is = null;
                es.close();
                es = null;
                os.close();
                os = null;
            } catch (IOException e) {
                return "";
            }

            proc.destroy();
            proc = null;
        }


        if (errorBuffer.length() > 0) {
            logger
                    .error("could not finish execution because of error(s).");
            logger.error("*** Error : " + errorBuffer.toString());
            return "";
        }


        return outputReport.toString();
    }

but when i try to exec command like :

/export/home/test/myapp -T "some argument"

myapp reads "some argument" as two seperated arguments.but I want to read "some argument" as only a argument. when i directly run this command from terminal, it executed successfully. I tried '"some argument"' ,""some argument"" , "some\ argument" but did not work for me. how can i read this argument as one argument.

score 16 · Accepted Answer · answered Mar 17 '10 at 06:43

16

I recall that the an overload of exec method provides a parameter for the arguments seperately. You need to use that

Yup. Here is it

public Process exec(String[] cmdarray)
             throws IOException

Just make the command line and all arguments Seperate elements of the String array

answered Mar 17 '10 at 06:43

Midhat

17,454
22
87
114

[When `Runtime.exec()` won’t: Navigate yourself around pitfalls related to the `Runtime.exec()` method](http://www.javaworld.com/article/2071275/core-java/when-runtime-exec---won-t.html) or possibly a future-proof [search engine query](https://duckduckgo.com/?q=When+Runtime.exec+wont+Navigate+yourself+around+pitfalls+related+to+the+Runtime.exec+method). – Greg Bacon Jun 09 '16 at 21:05

score -3 · Answer 2 · answered May 17 '11 at 17:02

-3

first make a string
String cmd="/export/home/test/myapp -T \"some argument\"";
then run cmd in proc

answered May 17 '11 at 17:02

Yasir

15

2

This does absolutely nothing other than what Aykut already pointed out. – Milad Naseri May 29 '12 at 11:57
@MiladNaseri Except that it properly escapes the quotes which was Aykut's actual mistake. – Silveri Aug 27 '13 at 09:10
@Silveri - Except that is doesn't work. You can't use quoting in a command string via Java. Java doesn't understand shell quoting. – Stephen C Mar 24 '18 at 02:24

run shell command from java

2 Answers2

Linked

Related