Popup doesn't opens if the parameters are long

Question

I'm making an application in which a popup needs to open on button click, which contains three parameters. Everything works if I only pass 1 parameter, but if I pass more parameters (they are long), then no popup opens. What might be the problem here?

<?php
         $number = mt_rand(1,50000); //generate anti-csrf token
         $entry = base64_encode($number);
         $escape = sha1($number);
         ?>
           <a href="#" onclick="javascript:popUp(<?php echo $reviews->companyid; ?>,<?php echo $entry; ?>,<?php echo $escape; ?>);">Concur</a> |

Popup opener

<script type="text/javascript">
  function popUp(id,entry,escape)
  {
    popupWindow = window.open('admin_browse_userprofile.php?id='+id+'&entry='+entry+'&escape='+escape,'User','resizable=yes,scrollbars=yes,width=650,height=550');
      popupWindow.focus();
  }
  </script>

Check this http://stackoverflow.com/questions/417142/what-is-the-maximum-length-of-a-url-in-different-browsers — Rafael, Jul 07 '14 at 16:09
What is the resulting Javascript that is generated from your PHP? Any errors in the JS console? — Adam, Jul 07 '14 at 16:09
@RafaelDiaz I have already gone through that link and nothing helped me. — user3605847, Jul 07 '14 at 16:14
I'm not sure what triggered the -1. Stackoverflow should add a facility that when someone gives a -1, the reason must be provided as well. — user3605847, Jul 07 '14 at 16:18

score 1 · Accepted Answer · answered Jul 07 '14 at 16:15

1

Only reason the first one works is because you have anumber and numbers do not need quotes.

It throws an error because you have strings that are not wrapped in quotes.

popUp(123,FOO,BAR);

should be

popUp(123,'FOO','BAR');

And if the text inside contains " and ' you need to handle those.

answered Jul 07 '14 at 16:15

epascarello

204,599
20
195
236

I changed my code to `javascript:popUp(companyid; ?>,'','');"` and it worked. Thank you. – user3605847 Jul 07 '14 at 16:18

Popup doesn't opens if the parameters are long

1 Answers1