4

I'm a beginner Java student. So any help will be much appreciated!

I've designed a class Cards and class Deck that I will use in a game that I've created. So far, my game seems to be working very well, but the problem I have lies in my Cards class. I'd like to utilize my getRank() method as a way to accumulate points for the cards a player has (regardless of suit).

For example, if they draw a 2 of Diamonds, it will be worth 2 points, 3 of hearts 3 points...ect. I've created a String[] called ranks to try to do this, and I think that's what it does. However, I'd like all face cards (like king, queen...) to have a value of 10. But not all these cards lie at index 10 in my array. Could I have some guidance as to how to go about adjusting this?

Thank you in advance.

int rank;
int suit;
String[]ranks = { " "," ", " " } //all 13 ranks from Ace to King 
String[]suits = { " ", " ", " "} //all ranks

public Card(int rank, int suit){
   this.rank = rank;
   this.suit = suit; 
}

public void setRank(int rank){
   this.rank = rank;
}

public int getRank(){
   return rank;
}

//more code for suits

public String toString(){
   return ranks[rank]+" of "+suits[suit];
}
aliteralmind
  • 19,847
  • 17
  • 77
  • 108
user3806226
  • 225
  • 1
  • 6
  • 14

2 Answers2

7

Enums are your friend. As you've discovered, ints are not appropriate, because they work for only some of the cases (ace through ten), and there's nothing stopping your user from giving an illegal value (negative or greater than 13). Enums can both enforce correct values, and also can also easily associate any numeric value you like.

public enum CardRank  {
   ACE(1),
   TWO(2),
   THREE(3),
   ...
   TEN(10),
   JACK(10),
   QUEEN(10),
   KING(10);

   private final int value;
   CardRank(int value)  {
      this.value = value;
   }
   public int getValue()  {
      return  value;
   }
}

Using this, you'd set the rank with

public void Card(CardRank rank, CardSuit suit)  {
   this.rank = rank;
   this.suit = suit;
}
public int getRankValue()  {
   return  rank.getValue();
}

Another benefit of enums is much clearer, self-documenting functions. If the parameters are both ints, then, by just looking at the signature's types, it's not clear which is the rank and which is the suit. With enums, it's a non-issue.

I'll leave CardSuit as an exercise :)

More info:

Community
  • 1
  • 1
aliteralmind
  • 19,847
  • 17
  • 77
  • 108
1

You could restructure your Card class to also have a 'value' or equivalent parameter used to store the point value of each card. However, point value is more of a piece of game logic. Maybe give your game a method getValue(Card c) that converts a card's rank into a value based upon your logic. The method could look like this

public int getValue(Card c) {
    if (c.getRank() > 10) {
        return 10;
    } else {
        return c.getRank();
    }
}
JustWannaFly
  • 301
  • 1
  • 11
  • This seems more within my current abilities to do, but I have my actual game in my main method.... so when I call myCard.getRank()... i can't seem to figure out how to make its values change :/ – user3806226 Jul 11 '14 at 21:34
  • Basically you would replace your call of `myCard.getRank()` with a method such as `Game.getValue(myCard)` The `getValue` method could look something like this `if (myCard.getRank() > 10) {return 10;} else {return myCard.getRank()}` – JustWannaFly Jul 11 '14 at 21:40
  • See the edit in the answer for a more clear representation of what the method could look like – JustWannaFly Jul 11 '14 at 21:46
  • that is a more elegant answer. you should probably function @resueman and @aliteralmind point out as the value logic in place of `myCard.getRank()` – JustWannaFly Jul 11 '14 at 22:02
  • 1
    Correction: `return Math.min(10, c.getRank());` – aliteralmind Jul 11 '14 at 22:11