forEach using generators in Node.js

Question

I'm using Koa.js framework and Mongoose.js module.

Normally to get a result from MongoDB I code like this:

var res = yield db.collection.findOne({id: 'my-id-here'}).exec();

But I need to execute this line for every element of an array named 'items'.

items.forEach(function(item) {
  var res = yield db.collection.findOne({id: item.id}).exec();
  console.log(res)  // undefined
});

But this code doesn't run as yield is in the function. If I write this:

items.forEach(function *(item) {
  var res = yield db.collection.findOne({id: item.id}).exec();
  console.log(res)  // undefined
});

I'm not getting the result in res variable either. I tried to use 'generator-foreach' module but that didn't worked like this.

I know that this is my lack of knowledge about the language literacy of Node.js. But can you guys help me finding a way how to do this?

I just replaced forEach with the generator-foreach. The rest of the code is same. Can you modify my code snippet and make sure that it's working? — Mazhar Ahmed, Jul 16 '14 at 18:39

Umidbek · Answer 1 · 2018-02-09T13:19:10.237

28

You can yield arrays, so just map your async promises in another map

var fetchedItems = yield items.map((item) => {
   return db.collection.findOne({id: item.id});
});

edited Feb 09 '18 at 13:19

answered Aug 14 '15 at 03:24

Umidbek

1,504
12
26

1

This is much simpler and should be the accepted answer. – Kevin Cooper Aug 18 '16 at 13:53

score 12 · Answer 2 · answered Jul 18 '16 at 21:24

The accepted answer is wrong, there is no need to use a library, an array is already an iterable.

This is an old question, but since it has no correct answer yet and it appears on the first page on google search for the key terms "iterators and forEach" I will respond the question:

There is no need to iterate over an array, since an array already conforms to the iterable API.

inside your generator just use "yield* array" (note the * ) yield* expression is used to delegate to another generator or iterable object

Example:

let arr = [2, 3, 4];

    function* g2() { 
      yield 1;
      yield* arr;
      yield 5;
    }

    var iterator = g2();

    console.log(iterator.next()); // { value: 1, done: false }
    console.log(iterator.next()); // { value: 2, done: false }
    console.log(iterator.next()); // { value: 3, done: false }
    console.log(iterator.next()); // { value: 4, done: false }
    console.log(iterator.next()); // { value: 5, done: false }
    console.log(iterator.next()); // { value: undefined, done: true }

For examples and in depth information visit: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/yield*

score 7 · Accepted Answer · edited Aug 12 '16 at 13:27

7

Thanks guys, I've done this using the 'CO' module. Thanks.

var co = require('co');

items.forEach(co(function* (item) {
  var img = yield db.collection.findOne({id: item.id}).exec();
}));

EDIT: With the latest version of CO, you need co.wrap() for this to work.

edited Aug 12 '16 at 13:27

joncodo

2,298
6
38
74

answered Jul 17 '14 at 05:00

Mazhar Ahmed

1,523
2
24
41

1

This does not work because `item` === `items` when it's wrapped with co() – az_ Oct 28 '14 at 20:40
5

If you use a standard for loop `for (x=0;x – az_ Dec 02 '14 at 18:36
I did the same afterword though. Good job finding it. Thanks. – Mazhar Ahmed Dec 03 '14 at 13:42
co has changed a bit. Now you need co.wrap() then this example works – joncodo Aug 12 '16 at 11:32
@az_ 's comment is the solution. forEach and anoy functions wrapped in co() does not seem to work, to get it working you need to use the for loop instead – newbreedofgeek Feb 19 '18 at 04:15

forEach using generators in Node.js

3 Answers3