App keeps stopping and I don't know what's going on

Question

I have a very simple application with two buttons and a text. I press one and the number on the text goes up. The other makes the number decrease. Here is my code.

package com.bryantpc.itemcounter;

import android.support.v7.app.ActionBarActivity;
import android.os.Bundle;
import android.view.View;
import android.view.View.OnClickListener;
import android.widget.Button;
import android.widget.TextView;

import com.bryantpc.itemcounter.R;

public class IC_MAIN extends ActionBarActivity {


 private int Amount1 = 0;

@Override
protected void onCreate(Bundle savedInstanceState) {
   super.onCreate(savedInstanceState);
   setContentView(R.layout.main);

   final Button Button1 = (Button)findViewById(R.id.button1);       
   final Button Button2 = (Button)findViewById(R.id.button2);       

   final TextView TextView1 = (TextView)findViewById(R.id.textView1);      

   Button1.setOnClickListener(new OnClickListener() {
       public void onClick(View v) {      
           Amount1++;
           TextView1.setText(Amount1);
       }
   });

   Button2.setOnClickListener(new OnClickListener() {
        public void onClick (View v) {
            Amount1--;
            TextView1.setText(Amount1);
        }
    });

Every time when I press one of the buttons, the app stops working. Anyone knows what's going on? P.S I have no LogCat because my emulator is not working I am running the APK on my phone.

http://stackoverflow.com/questions/23353173/unfortunately-myapp-has-stopped-how-can-i-solve-this — nhaarman, Jul 19 '14 at 14:16

score 2 · Accepted Answer · answered Jul 19 '14 at 14:12

2

You can't do TextView1.setText(Amount1) unless that is a resource ID, which in this case it isn't. Use TextView1.setText(String.valueOf(Amount1)) when setting the text.

As an aside, you should name your classes and variables according to something like https://source.android.com/source/code-style.html

answered Jul 19 '14 at 14:12

Dororo

3,420
2
30
46

So what should I change the `TextView1.setText(Amount1);` to? – Vincent Thacker Jul 19 '14 at 14:13
`TextView1.setText(String.valueOf(Amount1))` – Dororo Jul 19 '14 at 14:17
Thanks a lot! Just one last question... How do you limit the value to 0 or above? – Vincent Thacker Jul 19 '14 at 14:26
`if (Amount1 > 0)` then do `Amount1--` else do nothing. – Dororo Jul 19 '14 at 14:28
@Dororo: Over 2 years later ... the documention for TextView (https://developer.android.com/reference/android/widget/TextView.html#setText(java.lang.CharSequence) shows that you can have a `CharSequence` as a parameter instead of a resource ID. Was this not the case at the time? – Al Lelopath Mar 16 '17 at 20:11

App keeps stopping and I don't know what's going on

1 Answers1