Best way to control an object existence

Question

In many controllers, I need to verify if an object (ID passed in URL) exists.

I actually have this skeleton for each controller :

public function my_page($id){

$object = $this->Object_model->getObject($id);

if($object == NULL){ // If id mentions a non-existant object, redirect to home
  redirect("home");
}

/** MYCONTROLLER **/
}

Is it the good way, the cleanest way to do that ?

Some other options are helpers / model methods / controller methods... I don't know what is the PHP philosophy for that.

score 0 · Answer 1 · edited May 23 '17 at 10:25

0

Don't mix your controllers with the task to route the application. First you route and then you instantiate one of your controllers according to the given results.

Maybe this answer about routers clarifies what I mean: How does MVC routing work?

edited May 23 '17 at 10:25

Community

1
1

answered Jul 20 '14 at 16:28

chrisp

569
4
24

I don't see how I can do the control if ID exists with CI routing. Route sends a visitor with URL to my controller, I can't use any function or method except a regex between URL reading and the send to Controller – nlassaux Jul 20 '14 at 18:01

score 0 · Answer 2 · answered Jul 20 '14 at 18:37

0

The answer of your DB query is a boolean, so you must check if it's FALSE, and not NULL

public function my_page($id){

  $object = $this->Object_model->getObject($id);

  if($object === FALSE){
    redirect("home");
  }

  /** MYCONTROLLER **/
}

answered Jul 20 '14 at 18:37

Adrian Tombu

696
6
11

cartalot · Answer 3 · 2014-07-20T20:52:30.143

0

    if ( ! $object = $this->Object_model->getObject( $id ) ) {
        redirect( "home" ) ;       }

better would be Object_model always returning something whether there was an error or not.

   $object = $this->Object_model->getObject( $id ) ;

   if ( $object->errorFlag == true ) {
   redirect( "sorry/" . $object->errorMsg ) ; }

edited Jul 20 '14 at 20:52

answered Jul 20 '14 at 20:43

cartalot

3,147
1
16
14

So I should write something like that for all my controllers that load an object ? It will be quite repetitive no ? – nlassaux Jul 21 '14 at 05:47
need to see a use case and some code to respond appropriately. – cartalot Jul 21 '14 at 19:02

Best way to control an object existence

3 Answers3