DialogFragment: set buttons

Question

I'm trying to add buttons to a DialogFragment. My first approach was to declare the buttons on the fragment layout and then set OnClickListeners on the OnCreateView method. It did work, but as I was reading more about DialogFragment I realized you can add buttons on the OnCreateDialog method so I tried like this:

@Override
public Dialog onCreateDialog(Bundle savedInstanceState) {
    return new AlertDialog.Builder(getActivity())
            .setCancelable(true)
            .setPositiveButton(R.string.ok, null)
            .setNeutralButton(R.string.print, null)
            .setNegativeButton(R.string.cancel, null)
            .create();
}

But I keep getting this exception:

07-22 12:40:41.883  30960-30960/com.sellcom.tracker E/AndroidRuntime﹕ FATAL EXCEPTION: main
android.util.AndroidRuntimeException: requestFeature() must be called before adding content
        at com.android.internal.policy.impl.PhoneWindow.requestFeature(PhoneWindow.java:217)
        at com.android.internal.app.AlertController.installContent(AlertController.java:237)
        at android.app.AlertDialog.onCreate(AlertDialog.java:336)
        at android.app.Dialog.dispatchOnCreate(Dialog.java:351)
        at android.app.Dialog.show(Dialog.java:256)
        at android.support.v4.app.DialogFragment.onStart(DialogFragment.java:385)
        at android.support.v4.app.Fragment.performStart(Fragment.java:1524)
        at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:968)
        at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1115)
        at android.support.v4.app.BackStackRecord.run(BackStackRecord.java:682)
        at android.support.v4.app.FragmentManagerImpl.execPendingActions(FragmentManager.java:1478)
        at android.support.v4.app.FragmentManagerImpl$1.run(FragmentManager.java:446)
        at android.os.Handler.handleCallback(Handler.java:615)
        at android.os.Handler.dispatchMessage(Handler.java:92)
        at android.os.Looper.loop(Looper.java:153)
        at android.app.ActivityThread.main(ActivityThread.java:4987)
        at java.lang.reflect.Method.invokeNative(Native Method)
        at java.lang.reflect.Method.invoke(Method.java:511)
        at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:821)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:584)
        at dalvik.system.NativeStart.main(Native Method)

I've read a few tutorials but none says anything about it. The weird part is I'm not calling requestFeature() at any point of the code.

This was my previous code:

@Override
public Dialog onCreateDialog(Bundle savedInstanceState) {

    Dialog dialog = super.onCreateDialog(savedInstanceState);
    dialog.getWindow().requestFeature(Window.FEATURE_NO_TITLE);
    return dialog;
}

And this is where I inflate the custom view:

@Override
public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {

    View view = inflater.inflate(R.layout.fragment_receipt, container, false);

    if (view != null) {

        //Items of first view
        flipper = (ViewFlipper) view.findViewById(R.id.view_flipper);
        receiptNumber = (TextView) view.findViewById(R.id.receipt_number);
        receiptDate = (TextView) view.findViewById(R.id.receipt_date);
        issuedBy = (TextView) view.findViewById(R.id.issued_by);
        receivedBy = (TextView) view.findViewById(R.id.received_by);
        receiptSubtotal = (TextView) view.findViewById(R.id.receipt_subtotal);
        receiptTaxes = (TextView) view.findViewById(R.id.receipt_tax);
        receiptTotal = (TextView) view.findViewById(R.id.receipt_total);
        productsList = (ListView) view.findViewById(R.id.products_list);
        receiverSignature = (ImageView) view.findViewById(R.id.receiver_signature);
        issuingSignature = (ImageView) view.findViewById(R.id.issuing_signature);
        receiverName = (EditText) view.findViewById(R.id.receiver_name);
        issuingName = (EditText) view.findViewById(R.id.issuing_name);
        okButton = (Button) view.findViewById(R.id.ok_button);
        cancelButton = (Button) view.findViewById(R.id.cancel_button);
        printButton = (Button) view.findViewById(R.id.print_button);

        //Items of second view
        firstName = (EditText) view.findViewById(R.id.people_first_name);
        lastName = (EditText) view.findViewById(R.id.people_last_name);
        email = (EditText) view.findViewById(R.id.people_email);
        phone = (EditText) view.findViewById(R.id.people_phone);
        address1 = (EditText) view.findViewById(R.id.people_address_1);
        address2 = (EditText) view.findViewById(R.id.people_address_2);
        city = (EditText) view.findViewById(R.id.people_city);
        state = (EditText) view.findViewById(R.id.people_state);
        country = (EditText) view.findViewById(R.id.people_country);
        zipCode = (EditText) view.findViewById(R.id.people_zip_code);

        okButton.setOnClickListener(this);
        cancelButton.setOnClickListener(this);
        printButton.setOnClickListener(this);

        receiverSignature.setOnClickListener(this);
        issuingSignature.setOnClickListener(this);

        switch (receiptType) {
            case ReceiptAdapter.RECEIVING:
                receiptItems = createReceivingList();
                break;
            case ReceiptAdapter.SALE:
                receiptItems = createSalesList();
                break;
            case ReceiptAdapter.ORDER:
                receiptItems = createOrderList();

                receiptNumber.setVisibility(View.GONE);
                receiptDate.setVisibility(View.GONE);
                issuedBy.setVisibility(View.GONE);
                receivedBy.setVisibility(View.GONE);
                view.findViewById(R.id.issuing_layout).setVisibility(View.GONE);
                break;
        }

        ReceiptAdapter receiptAdapter = new ReceiptAdapter(getActivity(), receiptType, receiptItems);
        productsList.setAdapter(receiptAdapter);
    }

    return view;
}

All I did was change that for the code on the top. Am I missing something?

your problem isn't from the dialog. Where are you calling `requestFeature`? — LordRaydenMK, Jul 22 '14 at 17:46
thats your problem you need to call it and you need to call it before you setContentView() etc.. — erik, Jul 22 '14 at 17:49
Where should I call it? And also where in a `Fragment` do I call `setContentView()` — Carlos J, Jul 22 '14 at 17:51

intrepidkarthi · Accepted Answer · 2014-07-22T18:21:20.377

Try this. Call setView() before creating. Don't use both onCreateDialog and onCreateView

@Override
public Dialog onCreateDialog(Bundle savedInstanceState) {
    AlertDialog.Builder builder = new AlertDialog.Builder(getActivity());
    View view = getActivity().getLayoutInflater().inflate(R.layout.dialog_layout, null);
    builder.setView(view);
    if (view != null) {

    //Items of first view
    flipper = (ViewFlipper) view.findViewById(R.id.view_flipper);
    receiptNumber = (TextView) view.findViewById(R.id.receipt_number);
    receiptDate = (TextView) view.findViewById(R.id.receipt_date);
    issuedBy = (TextView) view.findViewById(R.id.issued_by);
    receivedBy = (TextView) view.findViewById(R.id.received_by);
    receiptSubtotal = (TextView) view.findViewById(R.id.receipt_subtotal);
    receiptTaxes = (TextView) view.findViewById(R.id.receipt_tax);
    receiptTotal = (TextView) view.findViewById(R.id.receipt_total);
    productsList = (ListView) view.findViewById(R.id.products_list);
    receiverSignature = (ImageView) view.findViewById(R.id.receiver_signature);
    issuingSignature = (ImageView) view.findViewById(R.id.issuing_signature);
    receiverName = (EditText) view.findViewById(R.id.receiver_name);
    issuingName = (EditText) view.findViewById(R.id.issuing_name);
    okButton = (Button) view.findViewById(R.id.ok_button);
    cancelButton = (Button) view.findViewById(R.id.cancel_button);
    printButton = (Button) view.findViewById(R.id.print_button);

    //Items of second view
    firstName = (EditText) view.findViewById(R.id.people_first_name);
    lastName = (EditText) view.findViewById(R.id.people_last_name);
    email = (EditText) view.findViewById(R.id.people_email);
    phone = (EditText) view.findViewById(R.id.people_phone);
    address1 = (EditText) view.findViewById(R.id.people_address_1);
    address2 = (EditText) view.findViewById(R.id.people_address_2);
    city = (EditText) view.findViewById(R.id.people_city);
    state = (EditText) view.findViewById(R.id.people_state);
    country = (EditText) view.findViewById(R.id.people_country);
    zipCode = (EditText) view.findViewById(R.id.people_zip_code);

    okButton.setOnClickListener(this);
    cancelButton.setOnClickListener(this);
    printButton.setOnClickListener(this);

    receiverSignature.setOnClickListener(this);
    issuingSignature.setOnClickListener(this);

    switch (receiptType) {
        case ReceiptAdapter.RECEIVING:
            receiptItems = createReceivingList();
            break;
        case ReceiptAdapter.SALE:
            receiptItems = createSalesList();
            break;
        case ReceiptAdapter.ORDER:
            receiptItems = createOrderList();

            receiptNumber.setVisibility(View.GONE);
            receiptDate.setVisibility(View.GONE);
            issuedBy.setVisibility(View.GONE);
            receivedBy.setVisibility(View.GONE);
            view.findViewById(R.id.issuing_layout).setVisibility(View.GONE);
            break;
    }

    ReceiptAdapter receiptAdapter = new ReceiptAdapter(getActivity(), receiptType, receiptItems);
    productsList.setAdapter(receiptAdapter);
}
    return builder.create();
}

That is where the problem comes. Can you show more code on it? — intrepidkarthi, Jul 22 '14 at 18:03
Ok, that worked! Now It's showing the `Dialog`. But where do I initialize all the widgets from my view? — Carlos J, Jul 22 '14 at 18:17
do it before the return statement after setting up the view. When you have both `oncreatedialog` and `oncreateview` it is trying to setup view even before nothing is initialized on your UI. — intrepidkarthi, Jul 22 '14 at 18:21

score 0 · Answer 2 · edited May 23 '17 at 12:05

0

requestWindowFeature(Window.FEATURE_NO_TITLE);

see this post: android.util.AndroidRuntimeException: requestFeature() must be called before adding content

hope this helps

edited May 23 '17 at 12:05

Community

1
1

answered Jul 22 '14 at 17:51

erik

4,946
13
70
120

That code is for an `Activity` right? But I'm using a `fragment`. I thought `Fragment`s don't use `setContentView()` – Carlos J Jul 22 '14 at 17:57

DialogFragment: set buttons

2 Answers2