Uncaught Error: Assertion Failed: calling set on destroyed object

Question

working in ember-cli testing. After all tests passed it returns extra two test with errors.

Uncaught Error: Assertion Failed: calling set on destroyed object Source : '../dist/assets/vendor.js:13269'

this is one unit test configuration

import Ember from "ember";
import { test,moduleFor } from 'ember-qunit';
import startApp from '../helpers/start-app';

var App;

module('An Integration test',{
    setup:function(){
        App=startApp();
    },
    teardown: function() {
        Ember.run(App, 'destroy');
    }
});

For me, I had to use `async/wait` while reading the object before destroying it — Rami Alloush, Dec 14 '22 at 17:20

score 52 · Accepted Answer · edited Oct 27 '14 at 04:44

52

This is either because in the result of a promise or any other deferred code you do not check the destroy status of an object, or because you didn't teardown something that has been setup and interact with DOM events or anything external to the core of Ember.

I used to have this especially on some jQuery plugins which I mapped to Ember, and during the tests the plugins were destroying too slowly and I was then either not using a run loop, or not checking the destroyed status of the Ember object I was manipulating.

You can do so with:

if ( !(obj.get('isDestroyed') || obj.get('isDestroying')) ) {
  // do your destroying code setting stuff
}

Also think about destroying any jQuery plugins that might have been initialised in the code of your views (anything setup in didInsertElement should be teardown in willDestroyElement for example).

edited Oct 27 '14 at 04:44

typeoneerror

55,990
32
132
223

answered Sep 16 '14 at 12:43

Huafu

2,445
1
22
26

What exactly do you mean by "// do you destroying code setting stuff"? I have the same issue where I am calling some this.$(document).on('click', '.myEl', function() { // do something });. I notice that this click handler doesn't work when the user navigates to a different route and comes back to the route that has the above code. Note that the click handler is within a view. – JackH Oct 28 '14 at 01:02
you should not listen to events like that. If the click event is relative to the view, you have to use the `eventManager` property of the view instead (see http://emberjs.com/api/classes/Ember.View.html#toc_event-managers). Anyway, you might have listened to some jQuery events and try to call some methods (including get/set) of ember objects. If so be sure to remove the event listeners in the `willDestroyElement`, and if you can't, surround your event function's body with this `if` I wrote, so that in case the Ember object is already destroyed or is destroying, you will not have errors – Huafu Oct 28 '14 at 05:18
I did wrap my jQuery selector inside the if statement you shared. I only replaced obj with 'this' which is the Ember object. Was that the right way to do it? I still see the error. – JackH Nov 20 '14 at 00:12
2

@Nagarjun I would add the linked answer as another answer to this question. – givanse Jan 20 '15 at 04:19
2

Future travelers: for a robust way to avoid this problem throughout your Ember apps, explore http://ember-concurrency.com/ – Sam Selikoff Jul 21 '16 at 12:58

score 15 · Answer 2 · edited Aug 18 '17 at 12:13

15

Ok i struggled with similar thing. So basically when you have "this.set()" inside a promise, it might happen that the promise takes too long to resolve, and the user already clicked away from that page, in this case you are trying to set something, that is already destroyed. I found the simplest solution to be just a simple check in the beginning of the promise.

if (this.isDestroyed) {
    return;
}
this.set('...');
...

Edit: alternatively you can use Ember.trySet.

edited Aug 18 '17 at 12:13

Jacob van Lingen

8,989
7
48
78

answered May 30 '16 at 14:05

Arntor

766
8
12

hi..what you did for this – Karthiga Apr 17 '19 at 05:10

score 2 · Answer 3 · answered Jul 10 '18 at 17:22

The issue is related to a promise not completely resolving and another test getting run immediately after.

You should give Ember Concurrency a try.

import { task, timeout } from 'ember-concurrency';

myFunction: task(function * () {

  // do somethinng

  yield timeout(1000); // wait for x milliseconds

  // do something else

}).drop(),

score 0 · Answer 4 · answered Mar 13 '18 at 01:38

I had a similar issue in an integration test. To resolve, in the integration test, I waited before performing the next action.

import wait from 'ember-test-helpers/wait';
wait().then(() => {
// perform action (which previously used to cause an exception)
});

Uncaught Error: Assertion Failed: calling set on destroyed object

4 Answers4

Linked