ng-click inside ng-repeat doesn't work with :focus and display

Question

Noob web developer here.

I want to know why this fiddle doesn't work. When you click on a link in the dropdown menu, I would expect an alert to appear, but none does. The button labeled 'yell' gives the desired behavior, but it's not a dropdown element.

Javascript

function apiCtrl($scope) {

    $scope.fish = [
        'blum',
        'blum',
        'shub'
    ];

    $scope.yell = function() {
        alert("HEY");
    };
}

HTML

<div ng-controller="apiCtrl">
    <button ng-click='yell()'>yell</button>
    <br>
    <input class='autocompleted' type='text'/>
    <ul>
        <li ng-repeat='f in fish' tabIndex='-1'>
            <a ng-click="$parent.yell()"> {{f}}
            </a>
        </li>
    </ul>
</div>

CSS

input.autocompleted + ul {
  display: none;
}

input.autocompleted:focus + ul {
  padding: 2px;
  margin: 1px;
  list-style-type: none;
  display: block;
  position: absolute;
  z-index: 2;
  background-color: #FFF;
  border: 1px solid #000;
}

I've looked for several solutions, and while there are quite a few, none of them have the added conundrum of inexperienced css mixed in. StackOverflow won't allow me more than two links in one post, so here's one of the solutions I looked at.

As you can see, I've used $parent to dodge the ngRepeat directive's transclusion.

I tried using $rootScope to create global access to yell(), as another solution suggested. No dice.

Removing the CSS makes it work, but what is it in there that breaks Angular?

[Here](http://stackoverflow.com/questions/19358798/angularjs-ng-click-event-not-firing-within-ng-repeat) [are](http://stackoverflow.com/questions/16745480/ng-click-nested-in-ng-repeat-does-not-fire) a few more solutions I looked at. — Mark Joseph Jorgensen, Aug 12 '14 at 01:20
[These](https://groups.google.com/forum/#!topic/angular/R935XesCYAA) [don't](http://stackoverflow.com/questions/21119838/ng-click-not-firing-in-ng-repeat) help either. — Mark Joseph Jorgensen, Aug 12 '14 at 01:21
Inorder for a click to happen, mousedown and mouseup must happen on the same element. In your case as mousedown happens it just hides.. You can see it here http://jsfiddle.net/aktobc0p/ — PSL, Aug 12 '14 at 01:23

score 3 · Accepted Answer · edited May 23 '17 at 10:33

In order for click event to execute on an element, mousedown and mouseup event needs to happen on the same element. In your case as the mousedown happens, the css rule input.autocompleted + ul{display: none;} comes into picture as you lose focus from the input, eventually mouseup never happens on that element and no click event executes. You can test this by changing <a ng-click="yell()"> to <a ng-mousedown="yell()"> and you will see the alert happening. Also a typical autocomplete does not show the items on click of the textbox instead generally when you type the characters in the suggestions show up. Possibly when you implement that you should not get into these issues.

Fiddle

On a side note, it would be better to use module.controller('controllerName', constructorWithDep) syntax since global scope controller discovery will be broken (Can opt in though) with version 1.3.

Another thing to mention that usage of $parent is not a good practice, instead you could use . syntax on the items being bound on the child scope. In your case you don't need that at all since yell is a function defined on its parent scope and is a reference type it will be automatically carried down via prototypical inheritance to its child scope(s).

ng-click inside ng-repeat doesn't work with :focus and display

Javascript

HTML

CSS

1 Answers1