Mvc model id 0 on post

Question

I have an edit page for my model. When i post model back to my controller, Id property is 0. How can i maintain Id property on post?

I'm posting model to view, so Id property is set on get request. My code is below.

View:

@model xandra.Models.ProjectModel

@using(Html.BeginForm())
{ 
    @Html.HiddenFor(m => m.Id) 
    @Html.LabelFor(m => m.Name)
    @Html.TextBoxFor(m => m.Name)

    <br />

    @Html.LabelFor(m => m.Description)
    @Html.TextAreaFor(m => m.Description)

    <br />

    @Html.LabelFor(m => m.Website)
    @Html.TextBoxFor(m => m.Website)

    <br />

    @Html.LabelFor(m => m.Active)
    @Html.CheckBoxFor(m => m.Active)

    <input type="submit" value="Save" />
}

Controller:

[Authorize]
[HttpGet]
[InitializeSimpleMembership]
public ActionResult EditProject(string id)
{
    using (var entity = new dixraContext())
    {
        var project = entity.Projects.FirstOrDefault(m => m.UrlName == id);


        return View(project);
    }
}

[Authorize]
[HttpPost]
[InitializeSimpleMembership]
public ActionResult EditProject(ProjectModel model)
{
    using (var entity = new dixraContext())
    {
        var project = entity.Projects.FirstOrDefault(m => m.Id == model.Id);

        project.Name = model.Name;
        project.Description = model.Description;
        project.Website = model.Website;
        project.Tags = model.Tags;
        project.Active = model.Active;

        entity.SaveChanges();

        return RedirectToAction("GetProject", project.UrlName);
    }
}

And my model

public class ProjectModel
{
    [Key]
    [Required]
    public long Id { get; set; }

    [Required(AllowEmptyStrings=false)]
    public string Name { get; set; }

    [Required(AllowEmptyStrings=false)]
    public string Description { get; set; }

    [Required]
    public DateTime CreatedDate { get; set; }

    [Required]
    public int Creator { get; set; }

    public string Website { get; set; }

    [Required]
    public int CategoryId { get; set; }

    public virtual List<TagModel> Tags { get; set; }

    public string UrlName { get; set; }

    public bool Active { get; set; }
}

Could you ensure that Id property has **getter and setter** - `public int Id { get; set; }`? — Win, Aug 19 '14 at 20:07
For reference : http://stackoverflow.com/questions/4710447/asp-net-mvc-html-hiddenfor-with-wrong-value — Jason Evans, Aug 19 '14 at 20:34

score 8 · Accepted Answer · answered Aug 19 '14 at 20:24

8

I've seen this happen before, it could be a bug. I have been able to work around it by adding the properties I need to be included in the post by not using the specific's view template syntax.

Instead of this:

@Html.HiddenFor(m => m.Id)

Use this:

<input type="hidden" value="@Model.Id" name="Id"/>

answered Aug 19 '14 at 20:24

Ricardo Sanchez

6,079
3
24
31

1

Don't know why this would fix it, but it did. – Don Rolling Nov 28 '16 at 19:26
May well be caused by the url. I had an ID in the url so this was being used by default. Above change worked to force it to use the model. – Alex Stephens Oct 29 '17 at 14:38
1

this does not fix it for me. – Mike Nov 26 '18 at 15:00

score 1 · Answer 2 · answered Aug 19 '14 at 22:34

I believe this is to do with asp.net MVC always forcing the model to be returned to the user as was posted to the server. You can override this behaviour using the following attribute...

void ControllerAction([Bind(Exclude = "Id")]SomeModel model)
{
  //action stuff here
}

score 1 · Answer 3 · answered Mar 26 '15 at 17:16

1

I had the same problem. There was identity specification missing on the DB table primary column, e.g. int identity(1,1). After fixing, entity framework stopped setting the id column to 0.

answered Mar 26 '15 at 17:16

Milan Švec

1,675
17
21

score 1 · Answer 4 · answered Aug 12 '20 at 19:51

Had the same problem. Here is solution: In controller class in action function (handled posted data) add line:

ModelState.Remove("Id");

If you don't do it, any value assigned by you to the Id property in the Model will be replaced with the value from POST request. So your Id change in the Model has no effect without removing it from ModelState.

score 0 · Answer 5 · answered Dec 23 '17 at 04:20

0

@Sefa

You are missing the id in controller action.

project.id = model.id; (missing)

project.Name = model.Name;
project.Description = model.Description;

answered Dec 23 '17 at 04:20

Code_Tracer

121
1
2
8

score 0 · Answer 6 · answered Jul 13 '18 at 19:38

If you are posting between pages make sure you do not have a hiddenfor on the page the value would be submitted. For example if page 1 sets value a to 1 and routes to page 2 then page 2 would have value a set as 1. However if you route page 2 back to page 1 and page 1 has a hiddenfor for the value you passed to page 2, it would be set the value to 0 if its a long or decimal. I hope this helps if someone is dealing with this problem posting values between different pages.

score 0 · Answer 7 · answered Oct 02 '20 at 00:31

0

I had the same problem, what solved it for me: changing the setter function from private to public.

answered Oct 02 '20 at 00:31

mtz

1

4

if possible, try and explain why this change solves this problem. – Jay Oct 02 '20 at 02:05

Mvc model id 0 on post

7 Answers7

Linked