Function won't call

Question

I have a function that is to be executed on click of a button. It is not working when I click the button. All of my other functions work when I click the button.

Javascript:

window.onload = function() {
    var button = document.getElementById("test");
    test.onclick = function() {
        var summonerid = document.getElementById("username").value.length;
        function summonerName() {
            if(summonerid = 4){
                alert("Come on");
            }
            else {
                alert("wai");
            }
        }
    }
}

Html:

<input type="text" name="summoner" id="username" maxlength="16" autocomplete="off" style="font-size: 22pt; font-family: times new roman">
<input type="submit" id="test" style="font-size: 22pt; font-family: times new roman">

If you mean `summonerName()` doesn't run then it's because it's never called. — GillesC, Aug 20 '14 at 00:02
You have `if set variable to 4`, when you mean `if variable is equal to`. One vs. two equal signs. — Jared Farrish, Aug 20 '14 at 00:02
I recommend to read the MDN JavaScript Guide about functions: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Functions — Felix Kling, Aug 20 '14 at 00:13

max · Answer 1 · 2014-08-20T00:23:50.280

1

Line by line corrections:

window.onload = function() {
    var button = document.getElementById("test");
    // Typo!
    button.onclick = function() {
        var summonerid = document.getElementById("username").value.length;
        // This was never called
        function summonerName(id) {
            // this assigned 4 to summonerid 
            if(id === 4){
                alert("Come on");
            }
            else {
                alert("wai");
            }
        }
        summonerName(summonerid);
    };

};

edited Aug 20 '14 at 00:23

answered Aug 20 '14 at 00:08

max

96,212
14
104
165

Shouldn't the `summonerName(summonerid);` be _inside_ the onclick listener? (Please clean indents) – Volune Aug 20 '14 at 00:17
You´re correct, I was writing in the browser and got lost in indentation... – max Aug 20 '14 at 00:25
1

By the way, `test.onclick` worked, since the element has id `test` so it's accessible with that name in the global scope. So it's more a bad practice than a typo. – Volune Aug 20 '14 at 00:27

score 0 · Answer 2 · answered Aug 20 '14 at 00:13

0

Well, You could simplify your code a bit like this

HTML :

 <input type="button" id="test" value="Submit" onclick="summonerName()"/>

JS :

function summonerName()
{
  var summonerid = document.getElementById("username").value.length;
  if(summonerid==4)
  {
    //Do what needs to be done
  }
}

Hope this helps.

answered Aug 20 '14 at 00:13

MDJ

266
2
8

Inline javascript is rarely a good idea. – max Aug 20 '14 at 00:14
2

Please note that there actual [practical disadvantages of using inline event handlers](http://stackoverflow.com/a/21975639/218196). – Felix Kling Aug 20 '14 at 00:14

Function won't call

2 Answers2