183

I have a counter hash that I am trying to sort by count. The problem I am running into is that the default Hash.sort function sorts numbers like strings rather than by number size.

i.e. Given Hash:

metrics = {"sitea.com" => 745, "siteb.com" => 9, "sitec.com" => 10 }

Running this code:

metrics.sort {|a1,a2| a2[1]<=>a1[1]}

will return a sorted array:

[ 'siteb.com', 9, 'sitea.com', 745, 'sitec.com', 10]

Even though 745 is a larger number than 9, 9 will appear first in the list. When trying to show who has the top count, this is making my life difficult. :)

Any ideas on how to sort a hash (or an array even) by number value size?

I appreciate any help.

Marc-André Lafortune
  • 78,216
  • 16
  • 166
  • 166
Dustin M.
  • 2,884
  • 3
  • 20
  • 18

4 Answers4

313

No idea how you got your results, since it would not sort by string value... You should reverse a1 and a2 in your example

Best way in any case (as per Mladen) is:

metrics = {"sitea.com" => 745, "siteb.com" => 9, "sitec.com" => 10 }
metrics.sort_by {|_key, value| value}
  # ==> [["siteb.com", 9], ["sitec.com", 10], ["sitea.com", 745]]

If you need a hash as a result, you can use to_h (in Ruby 2.0+)

metrics.sort_by {|_key, value| value}.to_h
  # ==> {"siteb.com" => 9, "sitec.com" => 10, "sitea.com", 745}
Marc-André Lafortune
  • 78,216
  • 16
  • 166
  • 166
102

Since value is the last entry, you can do:

metrics.sort_by(&:last)
shock_one
  • 5,845
  • 3
  • 28
  • 39
15

Already answered but still. Change your code to:

metrics.sort {|a1,a2| a2[1].to_i <=> a1[1].to_i }

Converted to strings along the way or not, this will do the job.

dimitarvp
  • 2,316
  • 2
  • 20
  • 29
10

That's not the behavior I'm seeing:

irb(main):001:0> metrics = {"sitea.com" => 745, "siteb.com" => 9, "sitec.com" =>
 10 }
=> {"siteb.com"=>9, "sitec.com"=>10, "sitea.com"=>745}
irb(main):002:0> metrics.sort {|a1,a2| a2[1]<=>a1[1]}
=> [["sitea.com", 745], ["sitec.com", 10], ["siteb.com", 9]]

Is it possible that somewhere along the line your numbers are being converted to strings? Is there more code you're not posting?

Jacob Mattison
  • 50,258
  • 9
  • 107
  • 126
  • Ahh your right it looks like the result in my code was returning it as a string. Pesky data types. :) Sometimes I am just too close to the problem. Thanks. – Dustin M. Mar 29 '10 at 22:18
  • 2
    Yup. Occasionally I hear someone refer to Ruby as "untyped". Oh, no, it's definitely typed. It's just not statically typed. :) – Jacob Mattison Mar 30 '10 at 01:05