My function is returning false when it should return true

Question

My function is always returning false when it should return true, and I can't find why

public function isReselling($key)
{
    if ($this->validateKey($key)) {
        return false;
    }
    $apis = mysql_connect("mysql.hostinger.fr", "u770656121_uapi", "testpass") or die(mysql_error());
    mysql_select_db("u770656121_api", $apis);
    $sql = "
    SELECT * FROM api_id
    ";
    $result = mysql_query($sql, $apis);
    while($row = mysql_fetch_array($result)) {
        $blacklisttho = $row['Banned'];
        if ($blacklisttho == 1) {
            return true;
        }
    }
    return false;
}

Which part of the function is returning false? Is it when it calls `$this->validateKey()` or after the mysql loop? — Barmar, Aug 21 '14 at 02:52
Why don't you use `SELECT COUNT(*) as found FROM api_id WHERE Banned = 1` to see if there are any of them? Then just see if `$row['found']` is more than 0. — Barmar, Aug 21 '14 at 02:54
[Please, don't use `mysql_*` functions](http://stackoverflow.com/q/12859942/1190388) in new code. They are no longer maintained and are [officially deprecated](https://wiki.php.net/rfc/mysql_deprecation). Learn about prepared statements instead, and use [tag:PDO] or [tag:MySQLi]. — hjpotter92, Aug 21 '14 at 02:56

score 1 · Answer 1 · answered Aug 21 '14 at 03:09

1

Well, you need to check where exactly the 'return' is beign made, and investigate based on that:

public function isReselling($key)
{
    if ($this->validateKey($key)) {

       die('validate fails');

        return false;
    }
    $apis = mysql_connect("mysql.hostinger.fr", "u770656121_uapi", "testpass") or die(mysql_error());
    mysql_select_db("u770656121_api", $apis);
    $sql = "
    SELECT * FROM api_id
    ";
    $result = mysql_query($sql, $apis);
    while($row = mysql_fetch_array($result)) {
        $blacklisttho = $row['Banned'];
        if ($blacklisttho == 1) {
            return true;
        }
    }

    die('no results.');

    return false;
}

and btw, you don't want to have multiple 'returns' around the code, that's bad practice.

answered Aug 21 '14 at 03:09

argamentor

148
5

SAys that the validate fails, but when I make if (!$this->validateKey($key)) { it always says that the key is banned – ax752 Aug 21 '14 at 03:24
Then that's what is happening: in your original code it always exits with false (because validateKey fails). – argamentor Aug 21 '14 at 13:09
It always return true when it should return false now :/ – ax752 Aug 21 '14 at 16:54

score 0 · Answer 2 · answered Aug 21 '14 at 13:10

I would change your code to something like:

public function isReselling($key)
{
    $retValue = false;

    if ($this->validateKey($key) === false) {
        $apis = mysql_connect("mysql.hostinger.fr", "u770656121_uapi", "testpass") or die(mysql_error());
        mysql_select_db("u770656121_api", $apis);
        $sql = "SELECT * FROM api_id";
        $result = mysql_query($sql, $apis);
        while($row = mysql_fetch_array($result)) {
            if ($row['Banned'] == 1) {
                $retValue = true;
                break;
            }
        }
    }
    return $retValue;
}

My function is returning false when it should return true

2 Answers2