Function is not getting called with the button in Android

Question

I'm trying to make my first Android application, and here is the problem i met:

When i am tapping the Yes Button, the function onYesButtonClick() is not called. The function is supposed to change the visibility of the TextView with the id TextView1, but when i tap, nothing happens. Here is the activity_main.xml:

<TextView
    android:id="@+id/TextView01"
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:layout_alignParentTop="true"
    android:layout_centerHorizontal="true"
    android:layout_marginTop="19dp"
    android:text="@string/q1" />

<TextView
    android:id="@+id/textView1"
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:layout_below="@+id/button1"
    android:layout_centerHorizontal="true"
    android:layout_marginTop="55dp"
    android:text="@string/hello_world"
    android:visibility="invisible" />

<Button
    android:id="@+id/button1"
    style="?android:attr/buttonStyleSmall"
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:layout_below="@+id/TextView01"
    android:layout_marginTop="22dp"
    android:layout_toLeftOf="@+id/textView1"
    android:onClick="onYesButtonClick"
    android:text="Yes" />

<Button
    android:id="@+id/button2"
    style="?android:attr/buttonStyleSmall"
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:layout_above="@+id/textView1"
    android:layout_toRightOf="@+id/textView1"
    android:onClick="onNoButtonClick"
    android:text="No" />

and here is the MainActivity.java:

 public class MainActivity extends ActionBarActivity {

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);
}

public void onYesButtonClick(View view){

     TextView textView = (TextView) findViewById(R.id.textView1);
     textView.setVisibility(android.view.View.VISIBLE);

}
public void onNoButtonClick(View view){


}
@Override
public boolean onCreateOptionsMenu(Menu menu) {
    // Inflate the menu; this adds items to the action bar if it is present.
    getMenuInflater().inflate(R.menu.main, menu);
    return true;
}

@Override
public boolean onOptionsItemSelected(MenuItem item) {
    // Handle action bar item clicks here. The action bar will
    // automatically handle clicks on the Home/Up button, so long
    // as you specify a parent activity in AndroidManifest.xml.
    int id = item.getItemId();
    if (id == R.id.action_settings) {
        return true;
    }
    return super.onOptionsItemSelected(item);
}

}

add some log message in onYesButtonClick and check if its been called or not — Piyush Kukadiya, Aug 22 '14 at 12:43
@blackbelt in that case can you give the answer. i will be glad to learn new way of declaring. — Aman Singh, Aug 22 '14 at 12:43
@AmanSingh refer this http://stackoverflow.com/questions/4153517/how-exactly-does-the-androidonclick-xml-attribute-differ-from-setonclicklistene — Piyush Kukadiya, Aug 22 '14 at 12:43
@PiyushKukadiya the function is called, and shows me a Toast, but it doesn't work when i'm trying to change the visibility of the textView1 — VIOO66, Aug 22 '14 at 12:50
@VIOO66 initialize your textview in onCreate method, [see below answer](http://stackoverflow.com/a/25447441/991085) — Giru Bhai, Aug 22 '14 at 12:52

score 0 · Accepted Answer · answered Aug 22 '14 at 12:48

0

declare textView in onCreate method because findViewById available in context of activity methods. So Change your code as

    TextView textView;
    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);
        textView= (TextView) findViewById(R.id.textView1);

    }

    public void onYesButtonClick(View view){
       textView.setVisibility(android.view.View.VISIBLE);
  }

answered Aug 22 '14 at 12:48

Giru Bhai

14,370
5
46
74

I tried to change this way, but the same result, it is not changing the visibility – VIOO66 Aug 22 '14 at 13:00
@VIOO66 Happy to help,enjoy coding. – Giru Bhai Aug 22 '14 at 13:11

score 0 · Answer 2 · answered Aug 22 '14 at 12:50

public class MainActivity extends Activity {

@Override
protected void onCreate(Bundle savedInstanceState) {
   super.onCreate(savedInstanceState);
   setContentView(R.layout.activity_main);
}

public void onYesButtonClick(View view){

    TextView textView = (TextView) findViewById(R.id.textView1);
    textView.setVisibility(View.VISIBLE);
}

public void onNoButtonClick(View view){
    TextView textView = (TextView) findViewById(R.id.textView1);
    textView.setVisibility(View.GONE);
}

}

score 0 · Answer 3 · answered Aug 22 '14 at 12:51

0

//this should be in your onCreate methord
TextView textView = (TextView) findViewById(R.id.textView1);

public void onYesButtonClick(View view){

     if(view.getID()==R.id.button1){
     textView.setVisibility(android.view.View.VISIBLE);
    }
}

answered Aug 22 '14 at 12:51

codePG

1,754
1
12
19

Function is not getting called with the button in Android

3 Answers3