Android HttpClient Upload File Error Handling

Question

I have an image uploader. If the internet connection stops an alert dialog is shown and asks the user if he want to retry or to cancel uploading. The problem is that sometimes when I retry, after the second uploading there are two images uploaded instead of one. What could be the problem?

Here is my code:

@Override
        protected Void doInBackground(Void... params) {
            Log.i("ImageUpload", "Uploading..");

            setBitmap();

            HttpClient httpClient = new DefaultHttpClient();

            HttpPost httpPostRequest = new HttpPost(url);

            httpPostRequest.setHeader("Cookie", this.cookie);

            MultipartEntityBuilder multiPartEntityBuilder = MultipartEntityBuilder
                    .create();

            ByteArrayOutputStream stream = new ByteArrayOutputStream();

            this.image.compress(Bitmap.CompressFormat.PNG, 100, stream);

            byte[] byteArray = stream.toByteArray();

            multiPartEntityBuilder.addBinaryBody("picture", byteArray,
                    ContentType.create("image/png"), "image.png");
            httpPostRequest.setEntity(multiPartEntityBuilder.build());

            try {
                HttpResponse httpResponse = null;

                Log.i("ImageUpload", "====================================================\n"
                        + "httpClient.execute(httpPostRequest)");

                httpResponse = httpClient.execute(httpPostRequest);
                Log.i("ImageUpload", "====================================================");
                Log.i("ImageUpload", "httpPost executed");

                InputStream inputStream = null;
                inputStream = httpResponse.getEntity().getContent();

                String result;
                if (inputStream != null) {
                    result = convertInputStreamToString(inputStream);
                } else {
                    result = "Unable to send signiture.";
                }

                Log.i("Upload result", result);
            } catch (IOException e) {
                photoSent = false;
                httpPostRequest.abort();
                this.cancel(true);
                e.printStackTrace();
            }

            return null;
        }

        @Override
        protected void onCancelled() {
            this.mainActivity.hideProgressBar();

            AlertDialog.Builder myAlertDialog = new AlertDialog.Builder(
                    mainActivity);
            myAlertDialog
                    .setTitle("Error why uploading the picture.");

            myAlertDialog.setNegativeButton("Cancel",
                    new DialogInterface.OnClickListener() {

                        @Override
                        public void onClick(DialogInterface dialog, int which) {
                            return;
                        }
                    });

            myAlertDialog.setPositiveButton("Retry",
                    new DialogInterface.OnClickListener() {

                        @Override
                        public void onClick(DialogInterface dialog, int which) {
                            /*execute the whole AsyncTask again*/
                        }
                    });

            myAlertDialog.show();

            super.onCancelled();
        }

Pratik Butani · Answer 1 · 2014-08-28T12:14:42.077

0

Try like this:

InputStream inputStream;
inputStream = new FileInputStream(new File(photoFile));
byte[] data;
data = IOUtils.toByteArray(inputStream);

httpClient.getParams().setParameter(CoreProtocolPNames.USER_AGENT,
System.getProperty("http.agent"));

InputStreamBody inputStreamBody = new InputStreamBody(new ByteArrayInputStream(data), "Pic.jpg");

MultipartEntityBuilder multipartEntity = MultipartEntityBuilder.create();
multipartEntity.setMode(HttpMultipartMode.BROWSER_COMPATIBLE);
multipartEntity.addPart("PhotoMessage", inputStreamBody);

httpPost.setEntity(multipartEntity.build());

HttpResponse httpResponse = httpClient.execute(httpPost);
HttpEntity httpEntity = httpResponse.getEntity();
is = httpEntity.getContent();

edited Aug 28 '14 at 12:14

answered Aug 28 '14 at 11:56

Pratik Butani

60,504
58
273
437

MultipartEntity is deprecated – dephinera Aug 28 '14 at 11:58
As you can see in my code, I use MultiparEntityBuilder... How your answer is solving my problem? – dephinera Aug 28 '14 at 12:07

score 0 · Accepted Answer · answered Aug 28 '14 at 14:18

0

I found the problem. I think the problem was that the connection is lost after the picture is sent but before the end of the request.

answered Aug 28 '14 at 14:18

dephinera

3,703
11
41
75

Android HttpClient Upload File Error Handling

2 Answers2