Show message before closing form

Question

I have this Window Form and what i need is that when i close the form by pressing [x] in the window, i need to show a message.

This is not working: Any idea why?

private void ControlCom_Closing(object sender, FormClosingEventArgs e)
{ 
        MessageBox.Show("test");    
}

I just need to display the message on button x click. But this doesn't display the message box.

Shuld i add anything else there or something? I read there is a closereason but mybe it's not the case.

You should handle form_Clothing not ControlCom_Clothing or whatever it is? — Meysam Tolouee, Sep 09 '14 at 09:46
Have you checked handler in Debug mode ..Might be some exception — Charlie, Sep 09 '14 at 09:47
Try overriding the onclosing method maybe http://stackoverflow.com/a/2906027/2296407 — Ms. Nobody, Sep 09 '14 at 09:50
@MAL Did you change the name of the handler_method without updating in designer? — Meysam Tolouee, Sep 09 '14 at 09:50
not fair I have posted ans before the person whom you accepted as answer!! :( — Neel, Sep 09 '14 at 11:43

Neel · Answer 1 · 2014-09-09T09:51:13.850

3

By the way The Closing event is obsolete, it dates from .NET 1.x. and it was replaced in .NET 2.0 with the FormClosing event.

So better try :-

private void ControlCom_FormClosing(object sender, FormClosingEventArgs e)
{
    MessageBox.Show("test");    
}

For more details :-

http://msdn.microsoft.com/en-us/library/system.windows.forms.form.formclosing(v=vs.110).aspx

edited Sep 09 '14 at 09:51

answered Sep 09 '14 at 09:45

Neel

11,625
3
43
61

hmm thanks, i tried it, but still, no popup message, maybe there's something overwriting it – MAL Sep 09 '14 at 09:46

score 2 · Answer 2 · edited Sep 09 '14 at 10:02

2

private void Form1_FormClosing(object sender, FormClosingEventArgs e)
{
    if (MessageBox.Show("Are you sure about closing the form?", "", MessageBoxButtons.YesNo) == DialogResult.No)
        e.Cancel = true;
}

edited Sep 09 '14 at 10:02

TaW

53,122
8
69
111

answered Sep 09 '14 at 09:48

Meysam Tolouee

569
3
17

You may want to prefix this by `if(e.CloseReason == CloseReason.UserClosing)` – TaW Sep 09 '14 at 10:01

Dmitry Bychenko · Accepted Answer · 2014-09-09T10:21:03.430

1

Typical scheme could be

private void Form1_FormClosing(object sender, FormClosingEventArgs e) {
  // If user (not system!) wants to close the form
  // but (s)he answered "no", do not close the form
  if (e.CloseReason == CloseReason.UserClosing)
    e.Cancel = MessageBox.Show(@"Do you really want to close the form?", 
                               Application.ProductName, 
                               MessageBoxButtons.YesNo) == DialogResult.No;
}

edited Sep 09 '14 at 10:21

answered Sep 09 '14 at 10:03

Dmitry Bychenko

180,369
20
160
215

You should always clothe your forms, especially in this weather ;) – Iain Ward Sep 09 '14 at 10:20
I liked it better before.. :( – Iain Ward Sep 09 '14 at 10:21
Does this prevent the problem of shutting down the system and not closing the form because of the warning. With `CloseReason.UserClosing` by shutting down the system it wouldn't end up asking the question? – Soon Santos Mar 07 '19 at 19:41

Show message before closing form

3 Answers3