OnCtrlColor Not Working?

Question

I used the following overloaded method to change the text color to red in a listbox, in a Visual C++ MFC dialog based application. When I build the program in DEBUG mode, it works perfectly. But when I use the RELEASE mode the text color doesn't change. Why is this and how can I overcome this problem??

Thanks!!

HBRUSH MyDlg::OnCtlColor(CDC* pDC, CWnd* pWnd, UINT nCtlColor)
{
  if(nCtlColor == CTLCOLOR_LISTBOX)
  {
     if(bChangeTextColor)
     {
       pDC->SetTextColor(RGB(255, 0, 0));
       return m_hRedBrush;
     }
  } 
  return CDialog::OnCtlColor(pDC, pWnd, nCtlColor);
}

Is the m_hRedBrush initialized properly in both Debug and Release builds? — sharptooth, Apr 06 '10 at 11:25
Yes, I checked that as well. But the problem is still persisting :( — Isuru, Apr 07 '10 at 03:31
@Isuru Did you ever come right with this because I am also having an issue with this? — Shane Haw, Aug 30 '13 at 05:54

score 9 · Answer 1 · edited Oct 22 '18 at 15:14

9

You must declare in MESSAGE_MAP

ex:

BEGIN_MESSAGE_MAP(CTrainMFCDlg, CDialog)
    ON_WM_SYSCOMMAND()    
    ON_WM_PAINT()    
    ON_WM_QUERYDRAGICON()    
    //}}AFX_MSG_MAP

    ON_WM_CTLCOLOR()  // your handle    
END_MESSAGE_MAP()

edited Oct 22 '18 at 15:14

Jabberwocky

48,281
17
65
115

answered Aug 31 '12 at 12:43

trongtien

91
1
1

score 3 · Answer 2 · answered Apr 07 '10 at 09:27

Can you try to call the base implementation CDialog::OnCtlColor before your custom code, like this:

HBRUSH MyDlg::OnCtlColor(CDC* pDC, CWnd* pWnd, UINT nCtlColor)
{
    HBRUSH hBrush=CDialog::OnCtlColor(pDC, pWnd, nCtlColor);

    if(nCtlColor == CTLCOLOR_LISTBOX)
    {
        if(bChangeTextColor)
        {
            pDC->SetTextColor(RGB(255, 0, 0));
            hBrush=m_hRedBrush;
        }
    } 
    return hBrush;
}

CDialog::OnCtlColor does some stuff internally which is skipped by your return inside of your function. It's only a very vague idea but I have always used OnCtlColor this way and never had a problem.

score 0 · Answer 3 · answered Feb 17 '17 at 13:42

I have to use both previous answers to make it work.

I declared handle in MESSAGE_MAP

BEGIN_MESSAGE_MAP(CTrainMFCDlg, CDialog)

    ON_WM_CTLCOLOR()  // your handle

END_MESSAGE_MAP()

I used CDialog::OnCtlColor before my custom code:

HBRUSH MyDlg::OnCtlColor(CDC* pDC, CWnd* pWnd, UINT nCtlColor)
{
     HBRUSH hBrush=CDialog::OnCtlColor(pDC, pWnd, nCtlColor);

     if(nCtlColor == CTLCOLOR_LISTBOX)
     {
          if(bChangeTextColor)
          {
               pDC->SetTextColor(RGB(255, 0, 0));
               hBrush=m_hRedBrush;
          }
    } 
    return hBrush;
}

OnCtrlColor Not Working?

3 Answers3