AsyncTask not completing as expected

Question

I have a CreateUser class which creates a user. This worked correctly until I tried to add a new field for a password check.

In the task I'm checking to see if the password fields match and if they dont I cancel the execution and move to a toast.

It correctly checks the passwords and toasts when incorrect but if they match it still cancels execution and never completes creating a new user.

CODE:

public class Register extends Activity implements OnClickListener{

private EditText user, pass, confirmPass;
private Button  mRegister;

// Progress Dialog
private ProgressDialog pDialog;

// JSON parser class
JSONParser jsonParser = new JSONParser();

private static final String LOGIN_URL = "https://xxx.xxx.xxx.xxx/xxx.php";

//ids
private static final String TAG_SUCCESS = "success";
private static final String TAG_MESSAGE = "message";

@Override
protected void onCreate(Bundle savedInstanceState) {
    // TODO Auto-generated method stub
    super.onCreate(savedInstanceState);
    setContentView(R.layout.register);

    user = (EditText)findViewById(R.id.username);
    pass = (EditText)findViewById(R.id.password);
    confirmPass = (EditText)findViewById(R.id.passwordConfirm);

    mRegister = (Button)findViewById(R.id.register);
    mRegister.setOnClickListener(this);

}

@Override
public void onClick(View v) {
    new CreateUser().execute();
}

 class CreateUser extends AsyncTask<String, String, String> {
    /**
     * Before starting background thread Show Progress Dialog
     * */
    boolean failure = false;

    @Override
    protected void onPreExecute() {
        super.onPreExecute();
        pDialog = new ProgressDialog(Register.this);
        pDialog.setMessage("Creating User...");
        pDialog.setIndeterminate(false);
        pDialog.setCancelable(true);
        pDialog.show();
    }

    @Override
    protected String doInBackground(String... args) {
        // TODO Auto-generated method stub
        // Check for success tag
        int success;
        String username = user.getText().toString();
        String password = pass.getText().toString();
        String passwordCheck = confirmPass.getText().toString();

            try {
//-----------------------------------------------------------------------------Password Check
                if (password != passwordCheck) {
                    cancel(true);
                }

                if (!this.isCancelled()) {
                    // Building Parameters
                    List<NameValuePair> params = new ArrayList<NameValuePair>();
                    params.add(new BasicNameValuePair("username", username));
                    params.add(new BasicNameValuePair("password", password));

                    Log.d("request!", "starting");

                    //Posting user data to script
                    JSONObject json = jsonParser.makeHttpRequest(
                            LOGIN_URL, "POST", params);

                    // full json response
                    Log.d("Login attempt", json.toString());

                    // json success element
                    success = json.getInt(TAG_SUCCESS);
                    if (success == 1) {
                        Log.d("User Created!", json.toString());
                        finish();
                        return json.getString(TAG_MESSAGE);
                    } else {
                        Log.d("Login Failure!", json.getString(TAG_MESSAGE));
                        return json.getString(TAG_MESSAGE);

                    }
                }
                }catch(JSONException e){
                    e.printStackTrace();
                }

                return null;
    }
    /**
     * After completing background task Dismiss the progress dialog
     * **/
    protected void onPostExecute(String file_url) {
        // dismiss the dialog once product deleted
        pDialog.dismiss();
        if (file_url != null){
            Toast.makeText(Register.this, file_url, Toast.LENGTH_LONG).show();
        }
}
    @Override
    protected void onCancelled() {
        pDialog.dismiss();
        Toast.makeText(Register.this, "Passwords do not match", Toast.LENGTH_SHORT).show();

    }
}}

You could check if they're equal and execute that task . it will make it easier . — Kiloreux, Sep 18 '14 at 20:07

Naveed · Accepted Answer · 2014-09-18T20:13:21.720

4

In your doInBackground, you're comparing 2 strings using != this will only compare the memory addresses of the strings and therefore will evaluate to false even if the value of the two strings is the same. Change it to equals()

edited Sep 18 '14 at 20:13

answered Sep 18 '14 at 20:08

Naveed

2,942
2
25
58

What a dopey mistake...it has been a long day; thank you Naveed. – Sep 18 '14 at 20:10

AsyncTask not completing as expected

1 Answers1