Update SQL doesn't work. No Error

Question

This is my code for updating. it displays "Done" but if you check the database, the fields are not updating.

What's wrong with my code?

<?php include('include/dbconnect.php');

$page = $_POST['newpage'];
$title = $_POST['newtitle'];
$content = $_POST['newcontent'];
$track_no = $_POST['track_no'];
$done = "UPDATE contents SET page = '$page',title = '$title', content = '$content', modified = 'CURDATE()'WHERE track_no = '$track_no' ";     
$result = mysql_query($done) or die(mysql_error());
if (!$result)
{
    print "Something is wrong!";
}
else{
    print "Done!";
}

?>

Echo your query and run in phpmyadmin. May be there you can see error — Khushboo, Sep 20 '14 at 05:42
Stack Snippets are meant for use with pure HTML, CSS, and JavaScript. They do not work with server-side languages like SQL and PHP at this time. — nhinkle, Sep 20 '14 at 05:47
@nhinkle thanks and i used to think those links are just some kind of add. I am new here — arif_suhail_123, Sep 20 '14 at 05:50
Your code is vulnerable to SQL injections. You should read on [how to prevent them in PHP](http://stackoverflow.com/q/60174/53114). — Gumbo, Sep 20 '14 at 05:51

score 0 · Answer 1 · answered Sep 20 '14 at 05:43

0

just remove quote from your sql

$done = "UPDATE contents SET page = '$page',title = '$title', content = '$content', modified = CURDATE() WHERE track_no = '$track_no' ";

answered Sep 20 '14 at 05:43

Lokesh Jain

579
6
19

This wouldn't result in a query not working, it would only result in the field being `0000-00-00`. – Gerald Schneider Sep 20 '14 at 07:32

RGK · Answer 2 · 2014-09-20T11:04:59.010

-1

your doing right one, but silly mistake only, YOU SHOULD MUST REMOVE THE SINGLE QUOTE IN CURDATE like as,

$done = "UPDATE contents SET 
page = '$page',
title = '$title', 
content = '$content', 
modified = CURDATE() 
WHERE 
track_no = '$track_no' ";

Note: Any kind of date or time don't mention in quote. Not this one 0000-00-00 00-00-00

edited Sep 20 '14 at 11:04

answered Sep 20 '14 at 07:04

RGK

40
9

This wouldn't result in a query not working, it would only result in the field being `0000-00-00`. Also, date or time values HAVE to have quotes. Function calls can't have quotes. – Gerald Schneider Sep 20 '14 at 07:32
[http://stackoverflow.com/a/25946267/3640589] @GeraldSchneider how did you score 5000 and above, hey you should must learn the mysql your query doesn't work, **because your missing the single quote** you should must changed the query and after u'll advise others.... – RGK Sep 20 '14 at 09:44
@GeraldSchneider do you want a upvote means tell me i'll give you, don't doing like this... – RGK Sep 20 '14 at 09:52

Update SQL doesn't work. No Error

2 Answers2