'in' is never closed

Question

there is a error in my code it is giving me a warning

Warning: Resource leak: 'in' is never closed

I have never had this problem before, in fact I tried old programs that I have written and it is still giving me the same issue. How do I fix this ?

import java.util.Scanner ;


public class CountVowels
{
   public static void main(String[] args)
   {
      Scanner in = new Scanner(System.in);
      System.out.println("Enter a word: ");
      String word = in.next();

      int vowelCount = 0;
      for (int i = 0; i < word.length(); i++)
      {
         char currentCharacter = word.charAt(i);
         if (currentCharacter == 'a' || currentCharacter == 'A'
            || currentCharacter == 'e' || currentCharacter == 'E'
            || currentCharacter == 'i' || currentCharacter == 'I'
            || currentCharacter == 'o' || currentCharacter == 'O'
            || currentCharacter == 'u' || currentCharacter == 'U')
         {
            vowelCount++;
         }
      }
      System.out.println(vowelCount + " vowel(s).");



   }
}

Close it? Or, even better, use `try`-with-resources to close it automatically. — chrylis -cautiouslyoptimistic-, Sep 20 '14 at 22:53
http://docs.oracle.com/javase/7/docs/api/java/util/Scanner.html#close() — xlm, Sep 20 '14 at 22:54

score 2 · Accepted Answer · edited May 23 '17 at 11:49

2

You will just need to close your scanner at the end of your function with:

in.close();

Like this:

public static void main(String[] args)
{
   Scanner in = new Scanner(System.in);
   // Do some stuff using the scanner
   in.close();
}

And also take a look here.

edited May 23 '17 at 11:49

Community

1
1

answered Sep 20 '14 at 22:53

pzaenger

11,381
3
45
46

2

+1, yup :). Even better would be for him to use a `try/catch` statement and also could add a `finally` to close the scanner – nem035 Sep 20 '14 at 22:56

'in' is never closed

1 Answers1