Echo all values from mysql column

Question

I am trying to echo all the values of 'comment' from a user defined table ($table_name)

$pdo = new PDO('mysql:dbname=db', 'user', 'pass');

$stmt2 = $pdo->query("SELECT comment FROM '$table_name'");

    if ($stmt2->rowCount() > 0) {

        $comments = $stmt2->fetchAll(PDO::FETCH_NUM);

        foreach ($comments as $comment) {

            $comm = $comment[0];
            echo $comm;

        }
    }

However I get this error:

Fatal error: Call to a member function rowCount() on a non-object in /FilePath/file.php on line 3

You have single quotes around the table name. Remove them. This is a typographical error and I'm voting to close. — Gordon Linoff, Sep 23 '14 at 02:47
Add `$pdo->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);` right after the connection is opened. This will signal errors found. Plus add error reporting to the top of your file(s) right after your opening ` — Funk Forty Niner, Sep 23 '14 at 02:47

score 1 · Accepted Answer · edited Sep 23 '14 at 03:02

1

No identifier quotes are backticks not single quotes.

`backticks`

// not 'table_name'
       ^ single quotes

Just take out that quotes. It will work just fine.

$stmt2 = $pdo->query("SELECT comment FROM $table_name");

Unless, as @Fred stated, your table name is a MySQL reserved word or has spaces or a hyphen (or any other character that SQL will disagree with), then you need to have them.

And as always, turn on error reporting.

$pdo->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION); // below the pdo connection
error_reporting(E_ALL);
ini_set('display_errors', '1');
// first lines of the file

edited Sep 23 '14 at 03:02

Funk Forty Niner

74,450
15
68
141

answered Sep 23 '14 at 02:47

Kevin

41,694
12
53
70

1

If OP's table name is called `keys`, or another possible reserved word, then it's best to answer "with" backticks. Let's assume *worse case scenario* ;) – Funk Forty Niner Sep 23 '14 at 02:51
I also noticed OP is missing `mysql:host=` – Funk Forty Niner Sep 23 '14 at 03:06
@Fred-ii- that seems to work fine, well, in my env, actually im not aware of that 'til i tested it a while ago when omitting the dsn – Kevin Sep 23 '14 at 03:07
So it's not always needed then? – Funk Forty Niner Sep 23 '14 at 03:07
@Fred-ii- seems to default to localhost when omitted – Kevin Sep 23 '14 at 03:07
1

Oh, well I'm going to have to try that out sometime. – Funk Forty Niner Sep 23 '14 at 03:08
1

That worked like a charm ,also @Fred-ii- i will make sure to add the mysql:host for future proofing in case I move the database to an external server. – Locke Donohoe Sep 23 '14 at 03:19
@LachlanDahlly sure no prob. glad it shed light – Kevin Sep 23 '14 at 03:20

Echo all values from mysql column

1 Answers1